database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-28 18:48:04 +03:00
Code Activity

Yet more elimination of dead stores and useless initializations.

Browse Source 
I'm not sure what tool Ranier was using, but the ones I contributed
were found by using a newer version of scan-build than I tried before.

Ranier Vilela and Tom Lane

Discussion: https://postgr.es/m/CAEudQAo1+AcGppxDSg8k+zF4+Kv+eJyqzEDdbpDg58-=MQcerQ@mail.gmail.com
This commit is contained in:
Tom Lane
2020-09-05 13:17:32 -04:00
parent 8febfd1855
commit a5cc4dab6d
10 changed files with 22 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/common/heaptuple.c
View File

@@ -736,7 +736,7 @@ expand_tuple(HeapTuple *targetHeapTuple,
{
AttrMissing *attrmiss = NULL;
int attnum;
int firstmissingnum = 0;
int firstmissingnum;
bool hasNulls = HeapTupleHasNulls(sourceTuple);
HeapTupleHeader targetTHeader;
HeapTupleHeader sourceTHeader = sourceTuple->t_data;

2
src/backend/access/gist/gistutil.c
View File

@@ -32,7 +32,6 @@
void
gistfillbuffer(Page page, IndexTuple *itup, int len, OffsetNumber off)
{
OffsetNumber l = InvalidOffsetNumber;
int i;
if (off == InvalidOffsetNumber)
@@ -42,6 +41,7 @@ gistfillbuffer(Page page, IndexTuple *itup, int len, OffsetNumber off)
for (i = 0; i < len; i++)
{
Size sz = IndexTupleSize(itup[i]);
OffsetNumber l;
l = PageAddItem(page, (Item) itup[i], sz, off, false, false);
if (l == InvalidOffsetNumber)

6
src/backend/access/nbtree/nbtsearch.c
View File

@@ -860,7 +860,7 @@ _bt_first(IndexScanDesc scan, ScanDirection dir)
ScanKeyData notnullkeys[INDEX_MAX_KEYS];
int keysCount = 0;
int i;
bool status = true;
bool status;
StrategyNumber strat_total;
BTScanPosItem *currItem;
BlockNumber blkno;
@@ -1858,7 +1858,7 @@ _bt_steppage(IndexScanDesc scan, ScanDirection dir)
{
BTScanOpaque so = (BTScanOpaque) scan->opaque;
BlockNumber blkno = InvalidBlockNumber;
bool status = true;
bool status;
Assert(BTScanPosIsValid(so->currPos));
@@ -1967,7 +1967,7 @@ _bt_readnextpage(IndexScanDesc scan, BlockNumber blkno, ScanDirection dir)
Relation rel;
Page page;
BTPageOpaque opaque;
bool status = true;
bool status;
rel = scan->indexRelation;