From a5bca2487244e48de1ece92d4c6a1ff330d5333c Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 26 Jul 2012 09:18:32 -0400 Subject: [PATCH] Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem caused the cancel. Crank up the level to LOG and add some more details to assist with debugging. Back-patch all the way, per discussion on pgsql-hackers. --- src/backend/storage/lmgr/proc.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index 327f43bb352..1fd8f9bf9a4 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1100,13 +1100,30 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) !(autovac_pgxact->vacuumFlags & PROC_VACUUM_FOR_WRAPAROUND)) { int pid = autovac->pid; + StringInfoData locktagbuf; + StringInfoData logbuf; /* errdetail for server log */ - elog(DEBUG2, "sending cancel to blocking autovacuum PID %d", - pid); + initStringInfo(&locktagbuf); + initStringInfo(&logbuf); + DescribeLockTag(&locktagbuf, &lock->tag); + appendStringInfo(&logbuf, + _("Process %d waits for %s on %s"), + MyProcPid, + GetLockmodeName(lock->tag.locktag_lockmethodid, + lockmode), + locktagbuf.data); - /* don't hold the lock across the kill() syscall */ + /* release lock as quickly as possible */ LWLockRelease(ProcArrayLock); + ereport(LOG, + (errmsg("sending cancel to blocking autovacuum PID %d", + pid), + errdetail_log("%s", logbuf.data))); + + pfree(logbuf.data); + pfree(locktagbuf.data); + /* send the autovacuum worker Back to Old Kent Road */ if (kill(pid, SIGINT) < 0) {