database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Fix problems seen when result of a subselect was used in an

Browse Source 
expression context (ie, not at the top level of a WHERE clause).  Examples
like this one work now:
SELECT name, value FROM t1 as touter WHERE
(value/(SELECT AVG(value) FROM t1 WHERE name = touter.name)) > 0.75;
This commit is contained in:
Tom Lane
1999-04-19 04:17:11 +00:00
parent 4438b70b94
commit a58843b49a
2 changed files with 57 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/backend/parser/parse_expr.c
View File

@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.41 1999/04/18 17:35:51 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.42 1999/04/19 04:17:11 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -312,14 +312,6 @@ transformExpr(ParseState *pstate, Node *expr, int precedence)
op_expr = make_op(op, lexpr, tent->expr);
/*
* HACK! Second IF is more valid but currently we
* don't support EXPR subqueries inside
* expressions generally, only in WHERE clauses.
* After fixing this, first IF must be removed.
*/
if (op_expr->typeOid != BOOLOID)
elog(ERROR, "parser: '%s' must return 'bool' to be used with subquery", op);
if (op_expr->typeOid != BOOLOID &&
sublink->subLinkType != EXPR_SUBLINK)
elog(ERROR, "parser: '%s' must return 'bool' to be used with quantified predicate subquery", op);
@ -598,7 +590,20 @@ exprType(Node *expr)
type = ((Param *) expr)->paramtype;
break;
case T_SubLink:
type = BOOLOID;
{
SubLink *sublink = (SubLink *) expr;
if (sublink->subLinkType == EXPR_SUBLINK)
{
/* return the result type of the combining operator */
Expr *op_expr = (Expr *) lfirst(sublink->oper);
type = op_expr->typeOid;
}
else
{
/* for all other sublink types, result is boolean */
type = BOOLOID;
}
}
break;
case T_CaseExpr:
type = ((CaseExpr *) expr)->casetype;