database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Ignore attempts to \gset into specially treated variables.

Browse Source 
If an interactive psql session used \gset when querying a compromised
server, the attacker could execute arbitrary code as the operating
system account running psql.  Using a prefix not found among specially
treated variables, e.g. every lowercase string, precluded the attack.
Fix by issuing a warning and setting no variable for the column in
question.  Users wanting the old behavior can use a prefix and then a
meta-command like "\set HISTSIZE :prefix_HISTSIZE".  Back-patch to 9.5
(all supported versions).

Reviewed by Robert Haas.  Reported by Nick Cleaton.

Security: CVE-2020-25696
This commit is contained in:
Noah Misch
2020-11-09 07:32:09 -08:00
parent aefc625ded
commit a54dfbee1f
5 changed files with 33 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/psql/common.c
View File

@@ -708,6 +708,13 @@ StoreQueryTuple(const PGresult *result)
/* concatenate prefix and column name */
varname = psprintf("%s%s", pset.gset_prefix, colname);
if (VariableHasHook(pset.vars, varname))
{
psql_error("attempt to \\gset into specially treated variable \"%s\" ignored\n",
varname);
continue;
}
if (!PQgetisnull(result, 0, i))
value = PQgetvalue(result, 0, i);
else