database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-25 12:03:53 +03:00
Code Activity

At end of recovery, reset all sinval-managed caches.

Browse Source 
An inplace update's invalidation messages are part of its transaction's
commit record.  However, the update survives even if its transaction
aborts or we stop recovery before replaying its transaction commit.
After recovery, a backend that started in recovery could update the row
without incorporating the inplace update.  That could result in a table
with an index, yet relhasindex=f.  That is a source of index corruption.

This bulk invalidation avoids the functional consequences.  A future
change can fix the !RecoveryInProgress() scenario without changing the
WAL format.  Back-patch to v17 - v12 (all supported versions).  v18 will
instead add invalidations to WAL.

Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com
This commit is contained in:
Noah Misch
2024-10-25 06:51:06 -07:00
parent e119076828
commit a4668c99f0
3 changed files with 68 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/include/storage/sinvaladt.h
View File

@@ -35,6 +35,7 @@ extern void SharedInvalBackendInit(bool sendOnly);
extern void SIInsertDataEntries(const SharedInvalidationMessage *data, int n);
extern int SIGetDataEntries(SharedInvalidationMessage *data, int datasize);
extern void SICleanupQueue(bool callerHasWriteLock, int minFree);
extern void SIResetAll(void);
extern LocalTransactionId GetNextLocalTransactionId(void);