database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-11 10:01:57 +03:00
Code Activity

Simplify GetLockNameFromTagType.

Browse Source 
The old code is wrong, because it returns a pointer to an automatic
variable.  And it's also more clever than we really need to be
considering that the case it's worrying about should never happen.
This commit is contained in:
Robert Haas
2016-03-10 21:37:22 -05:00
parent c94f0c29ce
commit a414d96ad2
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/storage/lmgr/lmgr.c
View File

@ -1003,17 +1003,7 @@ DescribeLockTag(StringInfo buf, const LOCKTAG *tag)
const char * const char *
GetLockNameFromTagType(uint16 locktag_type) GetLockNameFromTagType(uint16 locktag_type)
{ {
const char *locktypename; if (locktag_type > LOCKTAG_LAST_TYPE)
char tnbuf[32]; return "???";
return LockTagTypeNames[locktag_type];
if (locktag_type <= LOCKTAG_LAST_TYPE)
locktypename = LockTagTypeNames[locktag_type];
else
{
snprintf(tnbuf, sizeof(tnbuf), "unknown %d",
(int) locktag_type);
locktypename = tnbuf;
}
return locktypename;
} }