database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

In pg_upgrade, improve popen() failure detection by checking for fgets()

Browse Source 
failures.
This commit is contained in:
Bruce Momjian
2011-10-06 19:37:29 -04:00
parent 981e5acd24
commit a3996754cc
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/pg_upgrade/controldata.c
View File

@ -109,8 +109,8 @@ get_control_data(ClusterInfo *cluster, bool live_check)
fflush(stderr);
if ((output = popen(cmd, "r")) == NULL)
pg_log(PG_FATAL, "Could not get control data: %s\n",
getErrorText(errno));
pg_log(PG_FATAL, "Could not get control data using %s: %s\n",
cmd, getErrorText(errno));
/* Only pre-8.4 has these so if they are not set below we will check later */
cluster->controldata.lc_collate = NULL;