database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

Suppress compiler warning for get_am_type_string().

Browse Source 
Compilers that don't know that elog(ERROR) doesn't return complained
that this function might fail to return a value.  Per buildfarm.

While at it, const-ify the function's declaration, since the intent
is evidently to always return a constant string.
This commit is contained in:
Tom Lane 2016-03-24 17:22:24 -04:00
parent 0ecd3fedfc
commit a376960c8f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/commands/amcmds.c
View File

@ -30,7 +30,7 @@
static Oid lookup_index_am_handler_func(List *handler_name, char amtype); static Oid lookup_index_am_handler_func(List *handler_name, char amtype);
static char *get_am_type_string(char amtype); static const char *get_am_type_string(char amtype);
/* /*
@ -217,9 +217,9 @@ get_am_name(Oid amOid)
} }
/* /*
* Convert single charater access method type into string for error reporting. * Convert single-character access method type into string for error reporting.
*/ */
static char * static const char *
get_am_type_string(char amtype) get_am_type_string(char amtype)
{ {
switch (amtype) switch (amtype)
@ -229,6 +229,7 @@ get_am_type_string(char amtype)
default: default:
/* shouldn't happen */ /* shouldn't happen */
elog(ERROR, "invalid access method type '%c'", amtype); elog(ERROR, "invalid access method type '%c'", amtype);
return NULL; /* keep compiler quiet */
} }
} }