mirror of
https://github.com/postgres/postgres.git
synced 2025-06-11 20:28:21 +03:00
Allow decoding at prepare time in ReorderBuffer.
This patch allows PREPARE-time decoding of two-phase transactions (if the
output plugin supports this capability), in which case the transactions
are replayed at PREPARE and then committed later when COMMIT PREPARED
arrives.
Now that we decode the changes before the commit, the concurrent aborts
may cause failures when the output plugin consults catalogs (both system
and user-defined).
We detect such failures with a special sqlerrcode
ERRCODE_TRANSACTION_ROLLBACK introduced by commit 7259736a6e and stop
decoding the remaining changes. Then we rollback the changes when rollback
prepared is encountered.
Author: Ajin Cherian and Amit Kapila based on previous work by Nikhil Sontakke and Stas Kelvich
Reviewed-by: Amit Kapila, Peter Smith, Sawada Masahiko, Arseny Sher, and Dilip Kumar
Tested-by: Takamichi Osumi
Discussion:
https://postgr.es/m/02DA5F5E-CECE-4D9C-8B4B-418077E2C010@postgrespro.ru
https://postgr.es/m/CAMGcDxeqEpWj3fTXwqhSwBdXd2RS9jzwWscO-XbeCfso6ts3+Q@mail.gmail.com
This commit is contained in:
Amit Kapila
235
contrib/test_decoding/expected/twophase.out
Normal file
235
contrib/test_decoding/expected/twophase.out
Normal file
@ -0,0 +1,235 @@
|
||||
-- Test prepared transactions. When two-phase-commit is enabled, transactions are
|
||||
-- decoded at PREPARE time rather than at COMMIT PREPARED time.
|
||||
SET synchronous_commit = on;
|
||||
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
|
||||
?column?
|
||||
----------
|
||||
init
|
||||
(1 row)
|
||||
|
||||
CREATE TABLE test_prepared1(id integer primary key);
|
||||
CREATE TABLE test_prepared2(id integer primary key);
|
||||
-- Test that decoding happens at PREPARE time when two-phase-commit is enabled.
|
||||
-- Decoding after COMMIT PREPARED must have all the commands in the transaction.
|
||||
BEGIN;
|
||||
INSERT INTO test_prepared1 VALUES (1);
|
||||
INSERT INTO test_prepared1 VALUES (2);
|
||||
-- should show nothing because the xact has not been prepared yet.
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------
|
||||
(0 rows)
|
||||
|
||||
PREPARE TRANSACTION 'test_prepared#1';
|
||||
-- should show both the above inserts and the PREPARE TRANSACTION.
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
----------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:1
|
||||
table public.test_prepared1: INSERT: id[integer]:2
|
||||
PREPARE TRANSACTION 'test_prepared#1'
|
||||
(4 rows)
|
||||
|
||||
COMMIT PREPARED 'test_prepared#1';
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
----------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:1
|
||||
table public.test_prepared1: INSERT: id[integer]:2
|
||||
PREPARE TRANSACTION 'test_prepared#1'
|
||||
COMMIT PREPARED 'test_prepared#1'
|
||||
(5 rows)
|
||||
|
||||
-- Test that rollback of a prepared xact is decoded.
|
||||
BEGIN;
|
||||
INSERT INTO test_prepared1 VALUES (3);
|
||||
PREPARE TRANSACTION 'test_prepared#2';
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
----------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:3
|
||||
PREPARE TRANSACTION 'test_prepared#2'
|
||||
(3 rows)
|
||||
|
||||
ROLLBACK PREPARED 'test_prepared#2';
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
-------------------------------------
|
||||
ROLLBACK PREPARED 'test_prepared#2'
|
||||
(1 row)
|
||||
|
||||
-- Test prepare of a xact containing ddl. Leaving xact uncommitted for next test.
|
||||
BEGIN;
|
||||
ALTER TABLE test_prepared1 ADD COLUMN data text;
|
||||
INSERT INTO test_prepared1 VALUES (4, 'frakbar');
|
||||
PREPARE TRANSACTION 'test_prepared#3';
|
||||
-- confirm that exclusive lock from the ALTER command is held on test_prepared1 table
|
||||
SELECT 'test_prepared_1' AS relation, locktype, mode
|
||||
FROM pg_locks
|
||||
WHERE locktype = 'relation'
|
||||
AND relation = 'test_prepared1'::regclass;
|
||||
relation | locktype | mode
|
||||
-----------------+----------+---------------------
|
||||
test_prepared_1 | relation | RowExclusiveLock
|
||||
test_prepared_1 | relation | AccessExclusiveLock
|
||||
(2 rows)
|
||||
|
||||
-- The insert should show the newly altered column but not the DDL.
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
-------------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:4 data[text]:'frakbar'
|
||||
PREPARE TRANSACTION 'test_prepared#3'
|
||||
(3 rows)
|
||||
|
||||
-- Test that we decode correctly while an uncommitted prepared xact
|
||||
-- with ddl exists.
|
||||
--
|
||||
-- Use a separate table for the concurrent transaction because the lock from
|
||||
-- the ALTER will stop us inserting into the other one.
|
||||
--
|
||||
INSERT INTO test_prepared2 VALUES (5);
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
----------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared2: INSERT: id[integer]:5
|
||||
COMMIT
|
||||
(3 rows)
|
||||
|
||||
COMMIT PREPARED 'test_prepared#3';
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
-------------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:4 data[text]:'frakbar'
|
||||
PREPARE TRANSACTION 'test_prepared#3'
|
||||
COMMIT PREPARED 'test_prepared#3'
|
||||
(4 rows)
|
||||
|
||||
-- make sure stuff still works
|
||||
INSERT INTO test_prepared1 VALUES (6);
|
||||
INSERT INTO test_prepared2 VALUES (7);
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
--------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:6 data[text]:null
|
||||
COMMIT
|
||||
BEGIN
|
||||
table public.test_prepared2: INSERT: id[integer]:7
|
||||
COMMIT
|
||||
(6 rows)
|
||||
|
||||
-- Check 'CLUSTER' (as operation that hold exclusive lock) doesn't block
|
||||
-- logical decoding.
|
||||
BEGIN;
|
||||
INSERT INTO test_prepared1 VALUES (8, 'othercol');
|
||||
CLUSTER test_prepared1 USING test_prepared1_pkey;
|
||||
INSERT INTO test_prepared1 VALUES (9, 'othercol2');
|
||||
PREPARE TRANSACTION 'test_prepared_lock';
|
||||
SELECT 'test_prepared1' AS relation, locktype, mode
|
||||
FROM pg_locks
|
||||
WHERE locktype = 'relation'
|
||||
AND relation = 'test_prepared1'::regclass;
|
||||
relation | locktype | mode
|
||||
----------------+----------+---------------------
|
||||
test_prepared1 | relation | RowExclusiveLock
|
||||
test_prepared1 | relation | ShareLock
|
||||
test_prepared1 | relation | AccessExclusiveLock
|
||||
(3 rows)
|
||||
|
||||
-- The above CLUSTER command shouldn't cause a timeout on 2pc decoding. The
|
||||
-- call should return within a second.
|
||||
SET statement_timeout = '1s';
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
---------------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:8 data[text]:'othercol'
|
||||
table public.test_prepared1: INSERT: id[integer]:9 data[text]:'othercol2'
|
||||
PREPARE TRANSACTION 'test_prepared_lock'
|
||||
(4 rows)
|
||||
|
||||
RESET statement_timeout;
|
||||
COMMIT PREPARED 'test_prepared_lock';
|
||||
-- consume the commit
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
---------------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:8 data[text]:'othercol'
|
||||
table public.test_prepared1: INSERT: id[integer]:9 data[text]:'othercol2'
|
||||
PREPARE TRANSACTION 'test_prepared_lock'
|
||||
COMMIT PREPARED 'test_prepared_lock'
|
||||
(5 rows)
|
||||
|
||||
-- Test savepoints and sub-xacts. Creating savepoints will create
|
||||
-- sub-xacts implicitly.
|
||||
BEGIN;
|
||||
CREATE TABLE test_prepared_savepoint (a int);
|
||||
INSERT INTO test_prepared_savepoint VALUES (1);
|
||||
SAVEPOINT test_savepoint;
|
||||
INSERT INTO test_prepared_savepoint VALUES (2);
|
||||
ROLLBACK TO SAVEPOINT test_savepoint;
|
||||
PREPARE TRANSACTION 'test_prepared_savepoint';
|
||||
-- should show only 1, not 2
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared_savepoint: INSERT: a[integer]:1
|
||||
PREPARE TRANSACTION 'test_prepared_savepoint'
|
||||
(3 rows)
|
||||
|
||||
COMMIT PREPARED 'test_prepared_savepoint';
|
||||
-- consume the commit
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared_savepoint: INSERT: a[integer]:1
|
||||
PREPARE TRANSACTION 'test_prepared_savepoint'
|
||||
COMMIT PREPARED 'test_prepared_savepoint'
|
||||
(4 rows)
|
||||
|
||||
-- Test that a GID containing "_nodecode" gets decoded at commit prepared time.
|
||||
BEGIN;
|
||||
INSERT INTO test_prepared1 VALUES (20);
|
||||
PREPARE TRANSACTION 'test_prepared_nodecode';
|
||||
-- should show nothing
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------
|
||||
(0 rows)
|
||||
|
||||
COMMIT PREPARED 'test_prepared_nodecode';
|
||||
-- should be decoded now
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
---------------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.test_prepared1: INSERT: id[integer]:20 data[text]:null
|
||||
COMMIT
|
||||
(3 rows)
|
||||
|
||||
-- Test 8:
|
||||
-- cleanup and make sure results are also empty
|
||||
DROP TABLE test_prepared1;
|
||||
DROP TABLE test_prepared2;
|
||||
-- show results. There should be nothing to show
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------
|
||||
(0 rows)
|
||||
|
||||
SELECT pg_drop_replication_slot('regression_slot');
|
||||
pg_drop_replication_slot
|
||||
--------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
147
contrib/test_decoding/expected/twophase_stream.out
Normal file
147
contrib/test_decoding/expected/twophase_stream.out
Normal file
@ -0,0 +1,147 @@
|
||||
-- Test streaming of two-phase commits
|
||||
SET synchronous_commit = on;
|
||||
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
|
||||
?column?
|
||||
----------
|
||||
init
|
||||
(1 row)
|
||||
|
||||
CREATE TABLE stream_test(data text);
|
||||
-- consume DDL
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
|
||||
data
|
||||
------
|
||||
(0 rows)
|
||||
|
||||
-- streaming test with sub-transaction and PREPARE/COMMIT PREPARED
|
||||
BEGIN;
|
||||
SAVEPOINT s1;
|
||||
SELECT 'msg5' FROM pg_logical_emit_message(true, 'test', repeat('a', 50));
|
||||
?column?
|
||||
----------
|
||||
msg5
|
||||
(1 row)
|
||||
|
||||
INSERT INTO stream_test SELECT repeat('a', 2000) || g.i FROM generate_series(1, 35) g(i);
|
||||
TRUNCATE table stream_test;
|
||||
ROLLBACK TO s1;
|
||||
INSERT INTO stream_test SELECT repeat('a', 10) || g.i FROM generate_series(1, 20) g(i);
|
||||
PREPARE TRANSACTION 'test1';
|
||||
-- should show the inserts after a ROLLBACK
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');
|
||||
data
|
||||
----------------------------------------------------------
|
||||
streaming message: transactional: 1 prefix: test, sz: 50
|
||||
opening a streamed block for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
streaming change for transaction
|
||||
closing a streamed block for transaction
|
||||
preparing streamed transaction 'test1'
|
||||
(24 rows)
|
||||
|
||||
COMMIT PREPARED 'test1';
|
||||
--should show the COMMIT PREPARED and the other changes in the transaction
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');
|
||||
data
|
||||
-------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa1'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa2'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa3'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa4'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa5'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa6'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa7'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa8'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa9'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa10'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa11'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa12'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa13'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa14'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa15'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa16'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa17'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa18'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa19'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa20'
|
||||
PREPARE TRANSACTION 'test1'
|
||||
COMMIT PREPARED 'test1'
|
||||
(23 rows)
|
||||
|
||||
-- streaming test with sub-transaction and PREPARE/COMMIT PREPARED but with
|
||||
-- filtered gid. gids with '_nodecode' will not be decoded at prepare time.
|
||||
BEGIN;
|
||||
SAVEPOINT s1;
|
||||
SELECT 'msg5' FROM pg_logical_emit_message(true, 'test', repeat('a', 50));
|
||||
?column?
|
||||
----------
|
||||
msg5
|
||||
(1 row)
|
||||
|
||||
INSERT INTO stream_test SELECT repeat('a', 2000) || g.i FROM generate_series(1, 35) g(i);
|
||||
TRUNCATE table stream_test;
|
||||
ROLLBACK to s1;
|
||||
INSERT INTO stream_test SELECT repeat('a', 10) || g.i FROM generate_series(1, 20) g(i);
|
||||
PREPARE TRANSACTION 'test1_nodecode';
|
||||
-- should NOT show inserts after a ROLLBACK
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');
|
||||
data
|
||||
----------------------------------------------------------
|
||||
streaming message: transactional: 1 prefix: test, sz: 50
|
||||
(1 row)
|
||||
|
||||
COMMIT PREPARED 'test1_nodecode';
|
||||
-- should show the inserts but not show a COMMIT PREPARED but a COMMIT
|
||||
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'two-phase-commit', '1', 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');
|
||||
data
|
||||
-------------------------------------------------------------
|
||||
BEGIN
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa1'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa2'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa3'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa4'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa5'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa6'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa7'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa8'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa9'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa10'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa11'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa12'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa13'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa14'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa15'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa16'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa17'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa18'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa19'
|
||||
table public.stream_test: INSERT: data[text]:'aaaaaaaaaa20'
|
||||
COMMIT
|
||||
(22 rows)
|
||||
|
||||
DROP TABLE stream_test;
|
||||
SELECT pg_drop_replication_slot('regression_slot');
|
||||
pg_drop_replication_slot
|
||||
--------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
Reference in New Issue
Block a user