database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

More fixed for modern perl on back branches

Browse Source 
Use "do" instead of "require" for included files, as it doesn't look for
them in the search path but relative to the current working directory.
These changes have already been made to REL_10_STABLE and later, to
satisfy the demands of perlcritic, but need backporting now to earlier
branches.
This commit is contained in:
Andrew Dunstan
2019-02-05 18:31:10 -05:00
parent eae78da2b4
commit a25b049335
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/msvc/Install.pm
View File

@ -58,8 +58,8 @@ sub Install
# suppress warning about harmless redeclaration of $config # suppress warning about harmless redeclaration of $config
no warnings 'misc'; no warnings 'misc';
require "config_default.pl"; do "config_default.pl";
require "config.pl" if (-f "config.pl"); do "config.pl" if (-f "config.pl");
} }
chdir("../../..") if (-f "../../../configure"); chdir("../../..") if (-f "../../../configure");

8
src/tools/msvc/build.pl
View File

@ -21,17 +21,17 @@ use Mkvcbuild;
if (-e "src/tools/msvc/buildenv.pl") if (-e "src/tools/msvc/buildenv.pl")
{ {
require "src/tools/msvc/buildenv.pl"; do "src/tools/msvc/buildenv.pl";
} }
elsif (-e "./buildenv.pl") elsif (-e "./buildenv.pl")
{ {
require "./buildenv.pl"; do "./buildenv.pl";
} }
# set up the project # set up the project
our $config; our $config;
require "config_default.pl"; do "config_default.pl";
require "config.pl" if (-f "src/tools/msvc/config.pl"); do "config.pl" if (-f "src/tools/msvc/config.pl");
my $vcver = Mkvcbuild::mkvcbuild($config); my $vcver = Mkvcbuild::mkvcbuild($config);

2
src/tools/msvc/builddoc.pl
View File

@ -18,7 +18,7 @@ chdir '../../..' if (-d '../msvc' && -d '../../../src');
noversion() unless -e 'doc/src/sgml/version.sgml'; noversion() unless -e 'doc/src/sgml/version.sgml';
require 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl'; do 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl';
my $docroot = $ENV{DOCROOT}; my $docroot = $ENV{DOCROOT};
die "bad DOCROOT '$docroot'" unless ($docroot && -d $docroot); die "bad DOCROOT '$docroot'" unless ($docroot && -d $docroot);

4
src/tools/msvc/install.pl
View File

@ -18,11 +18,11 @@ use Install qw(Install);
if (-e "src/tools/msvc/buildenv.pl") if (-e "src/tools/msvc/buildenv.pl")
{ {
require "src/tools/msvc/buildenv.pl"; do "src/tools/msvc/buildenv.pl";
} }
elsif (-e "./buildenv.pl") elsif (-e "./buildenv.pl")
{ {
require "./buildenv.pl"; do "./buildenv.pl";
} }
my $target = shift || Usage(); my $target = shift || Usage();

4
src/tools/msvc/mkvcbuild.pl
View File

@ -23,7 +23,7 @@ print "Warning: no config.pl found, using default.\n"
unless (-f 'src/tools/msvc/config.pl'); unless (-f 'src/tools/msvc/config.pl');
our $config; our $config;
require 'src/tools/msvc/config_default.pl'; do 'src/tools/msvc/config_default.pl';
require 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl'); do 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl');
Mkvcbuild::mkvcbuild($config); Mkvcbuild::mkvcbuild($config);

2
src/tools/msvc/pgbison.pl
View File

@ -7,7 +7,7 @@ use File::Basename;
# assume we are in the postgres source root # assume we are in the postgres source root
require 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl'; do 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl';
my ($bisonver) = `bison -V`; # grab first line my ($bisonver) = `bison -V`; # grab first line
$bisonver = (split(/\s+/, $bisonver))[3]; # grab version number $bisonver = (split(/\s+/, $bisonver))[3]; # grab version number

2
src/tools/msvc/pgflex.pl
View File

@ -10,7 +10,7 @@ use File::Basename;
# assume we are in the postgres source root # assume we are in the postgres source root
require 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl'; do 'src/tools/msvc/buildenv.pl' if -e 'src/tools/msvc/buildenv.pl';
my ($flexver) = `flex -V`; # grab first line my ($flexver) = `flex -V`; # grab first line
$flexver = (split(/\s+/, $flexver))[1]; $flexver = (split(/\s+/, $flexver))[1];

6
src/tools/msvc/vcregress.pl
View File

@ -22,8 +22,8 @@ chdir "../../.." if (-d "../../../src/tools/msvc");
my $topdir = getcwd(); my $topdir = getcwd();
my $tmp_installdir = "$topdir/tmp_install"; my $tmp_installdir = "$topdir/tmp_install";
require 'src/tools/msvc/config_default.pl'; do 'src/tools/msvc/config_default.pl';
require 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl'); do 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl');
# buildenv.pl is for specifying the build environment settings # buildenv.pl is for specifying the build environment settings
# it should contain lines like: # it should contain lines like:
@ -31,7 +31,7 @@ require 'src/tools/msvc/config.pl' if (-f 'src/tools/msvc/config.pl');
if (-e "src/tools/msvc/buildenv.pl") if (-e "src/tools/msvc/buildenv.pl")
{ {
require "src/tools/msvc/buildenv.pl"; do "src/tools/msvc/buildenv.pl";
} }
my $what = shift || ""; my $what = shift || "";