database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

Fix race in 032_relfilenode_reuse.pl.

Browse Source 
Add wait_for_catchup() call to the test added by commit e2f65f42.  Per
slow build farm animal grison.

Also fix a comment.

Discussion: https://postgr.es/m/CA%2BhUKGLJ2Vy8hVQmnYotmTaEKZK0%3D-GcXgNAgcHzArZvtS4L_g%40mail.gmail.com
This commit is contained in:
Thomas Munro 2022-05-08 16:54:09 +12:00
parent ad76c9708b
commit a22652ebbc
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/recovery/t/032_relfilenode_reuse.pl
View File

@ -72,6 +72,8 @@ $node_primary->safe_psql('postgres', q[
CREATE TABLE replace_sb(data text); CREATE TABLE replace_sb(data text);
INSERT INTO replace_sb(data) SELECT random()::text FROM generate_series(1, 15000);]); INSERT INTO replace_sb(data) SELECT random()::text FROM generate_series(1, 15000);]);
$node_primary->wait_for_catchup($node_standby);
# Use longrunning transactions, so that AtEOXact_SMgr doesn't close files # Use longrunning transactions, so that AtEOXact_SMgr doesn't close files
send_query_and_wait( send_query_and_wait(
\%psql_primary, \%psql_primary,
@ -101,9 +103,9 @@ verify($node_primary, $node_standby, 1,
# value so we can check everything is OK # value so we can check everything is OK
$node_primary->safe_psql('conflict_db', "UPDATE large SET datab = 2;"); $node_primary->safe_psql('conflict_db', "UPDATE large SET datab = 2;");
# Again cause a lot of IO. That'll again write back dirty data, but uses (XXX # Again cause a lot of IO. That'll again write back dirty data, but uses newly
# adjust after bugfix) the already opened file descriptor. # opened file descriptors, so we don't confuse old files with new files despite
# FIXME # recycling relfilenodes.
cause_eviction(\%psql_primary, \%psql_standby); cause_eviction(\%psql_primary, \%psql_standby);
verify($node_primary, $node_standby, 2, verify($node_primary, $node_standby, 2,