database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Rename SetSingleFuncCall() to InitMaterializedSRF()

Browse Source 
Per discussion, the existing routine name able to initialize a SRF
function with materialize mode is unpopular, so rename it.  Equally, the
flags of this function are renamed, as of:
- SRF_SINGLE_USE_EXPECTED -> MAT_SRF_USE_EXPECTED_DESC
- SRF_SINGLE_BLESS -> MAT_SRF_BLESS
The previous function and flags introduced in 9e98583 are kept around
for compatibility purposes, so as any extension code already compiled
with v15 continues to work as-is.  The declarations introduced here for
compatibility will be removed from HEAD in a follow-up commit.

The new names have been suggested by Andres Freund and Melanie
Plageman.

Discussion: https://postgr.es/m/20221013194820.ciktb2sbbpw7cljm@awork3.anarazel.de
Backpatch-through: 15
This commit is contained in:
Michael Paquier
2022-10-18 10:22:35 +09:00
parent 77dd153d39
commit a19e5cee63
36 changed files with 72 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/amcheck/verify_heapam.c
View File

@ -278,7 +278,7 @@ verify_heapam(PG_FUNCTION_ARGS)
ctx.attnum = -1;
/* Construct the tuplestore and tuple descriptor */
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
ctx.tupdesc = rsinfo->setDesc;
ctx.tupstore = rsinfo->setResult;

2
contrib/dblink/dblink.c
View File

@ -1933,7 +1933,7 @@ dblink_get_notify(PG_FUNCTION_ARGS)
else
conn = pconn->conn;
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
PQconsumeInput(conn);
while ((notify = PQnotifies(conn)) != NULL)

2
contrib/pageinspect/brinfuncs.c
View File

@ -147,7 +147,7 @@ brin_page_items(PG_FUNCTION_ARGS)
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to use raw page functions")));
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
indexRel = index_open(indexRelid, AccessShareLock);

4
contrib/pageinspect/gistfuncs.c
View File

@ -127,7 +127,7 @@ gist_page_items_bytea(PG_FUNCTION_ARGS)
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to use raw page functions")));
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
page = get_page_from_raw(raw_page);
@ -211,7 +211,7 @@ gist_page_items(PG_FUNCTION_ARGS)
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to use raw page functions")));
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
/* Open the relation */
indexRel = index_open(indexRelid, AccessShareLock);

2
contrib/pg_stat_statements/pg_stat_statements.c
View File

@ -1552,7 +1552,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("pg_stat_statements must be loaded via shared_preload_libraries")));
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
/*
* Check we have the expected number of output arguments. Aside from

4
contrib/pg_walinspect/pg_walinspect.c
View File

@ -330,7 +330,7 @@ GetWALRecordsInfo(FunctionCallInfo fcinfo, XLogRecPtr start_lsn,
Datum values[PG_GET_WAL_RECORDS_INFO_COLS] = {0};
bool nulls[PG_GET_WAL_RECORDS_INFO_COLS] = {0};
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
xlogreader = InitXLogReaderState(start_lsn);
@ -548,7 +548,7 @@ GetWalStats(FunctionCallInfo fcinfo, XLogRecPtr start_lsn,
Datum values[PG_GET_WAL_STATS_COLS] = {0};
bool nulls[PG_GET_WAL_STATS_COLS] = {0};
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
xlogreader = InitXLogReaderState(start_lsn);

2
contrib/pgrowlocks/pgrowlocks.c
View File

@ -75,7 +75,7 @@ pgrowlocks(PG_FUNCTION_ARGS)
AclResult aclresult;
char **values;
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
/* Access the table */
relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname));

2
contrib/postgres_fdw/connection.c
View File

@ -1668,7 +1668,7 @@ postgres_fdw_get_connections(PG_FUNCTION_ARGS)
HASH_SEQ_STATUS scan;
ConnCacheEntry *entry;
SetSingleFuncCall(fcinfo, 0);
InitMaterializedSRF(fcinfo, 0);
/* If cache doesn't exist, we return no records */
if (!ConnectionHash)

2
contrib/xml2/xpath.c
View File

@ -511,7 +511,7 @@ xpath_table(PG_FUNCTION_ARGS)
PgXmlErrorContext *xmlerrcxt;
volatile xmlDocPtr doctree = NULL;
SetSingleFuncCall(fcinfo, SRF_SINGLE_USE_EXPECTED);
InitMaterializedSRF(fcinfo, MAT_SRF_USE_EXPECTED_DESC);
/* must have at least one output column (for the pkey) */
if (rsinfo->setDesc->natts < 1)