database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Improve the comments in 004_subscription.pl.

Browse Source 
It was not clear whether the subscriptions in the upgraded instance were
the ones that retained the previous subscription's properties.

Author: Peter Smith
Reviewed-by: Vignesh C, Alvaro Herrera
Discussion: https://postgr.es/m/CAHut+Pu1usLPHRySPTacY1K_Q-ddSRXNFhmj_2u1NfqBC1ytng@mail.gmail.com
This commit is contained in:
Amit Kapila 2024-02-05 08:51:33 +05:30
parent 2889fd23be
commit a17aa50d67
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/bin/pg_upgrade/t/004_subscription.pl
View File

@ -108,8 +108,8 @@ $old_sub->stop;
# ------------------------------------------------------ # ------------------------------------------------------
# Check that pg_upgrade is successful when all tables are in ready or in # Check that pg_upgrade is successful when all tables are in ready or in
# init state (tab_upgraded1 table is in ready state and tab_upgraded2 table is # init state (tab_upgraded1 table is in ready state and tab_upgraded2 table is
# in init state) along with retaining the replication origin's remote lsn # in init state) along with retaining the replication origin's remote lsn,
# and subscription's running status. # subscription's running status, and failover option.
# ------------------------------------------------------ # ------------------------------------------------------
command_ok( command_ok(
[ [
@ -137,15 +137,15 @@ $publisher->safe_psql(
$new_sub->start; $new_sub->start;
# The subscription's running status and failover option should be preserved. # The subscription's running status and failover option should be preserved
# Old subscription regress_sub1 should have enabled and failover as true while # in the upgraded instance. So regress_sub1 should still have subenabled and
# old subscription regress_sub2 should have enabled and failover as false. # subfailover set to true, while regress_sub2 should have both set to false.
$result = $result =
$new_sub->safe_psql('postgres', $new_sub->safe_psql('postgres',
"SELECT subname, subenabled, subfailover FROM pg_subscription ORDER BY subname"); "SELECT subname, subenabled, subfailover FROM pg_subscription ORDER BY subname");
is( $result, qq(regress_sub1|t|t is( $result, qq(regress_sub1|t|t
regress_sub2|f|f), regress_sub2|f|f),
"check that the subscription's running status are preserved"); "check that the subscription's running status and failover are preserved");
my $sub_oid = $new_sub->safe_psql('postgres', my $sub_oid = $new_sub->safe_psql('postgres',
"SELECT oid FROM pg_subscription WHERE subname = 'regress_sub2'"); "SELECT oid FROM pg_subscription WHERE subname = 'regress_sub2'");