database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

pgcrypto: fix memset() calls that might be optimized away

Browse Source 
Specifically, on-stack memset() might be removed, so:

	* Replace memset() with px_memset()
	* Add px_memset to copy_crlf()
	* Add px_memset to pgp-s2k.c

Patch by Marko Kreen

Report by PVS-Studio

Backpatch through 8.4.
This commit is contained in:
Bruce Momjian
2014-04-17 12:37:53 -04:00
parent 83defef8c7
commit 9fe55259fd
22 changed files with 82 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/pgcrypto/pgp-pgsql.c
View File

@ -87,7 +87,7 @@ add_block_entropy(PX_MD *md, text *data)
px_add_entropy(sha1, 20);
memset(sha1, 0, 20);
px_memset(sha1, 0, 20);
}
/*
@ -129,7 +129,7 @@ add_entropy(text *data1, text *data2, text *data3)
add_block_entropy(md, data3);
px_md_free(md);
memset(rnd, 0, sizeof(rnd));
px_memset(rnd, 0, sizeof(rnd));
}
/*
@ -167,7 +167,7 @@ convert_to_utf8(text *src)
static void
clear_and_pfree(text *p)
{
memset(p, 0, VARSIZE(p));
px_memset(p, 0, VARSIZE(p));
pfree(p);
}