database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-02 11:44:50 +03:00
Code

Fix bug so logical rep launcher saves correctly time of last startup of worker.

Browse Source 
Previously the logical replication launcher stored the last timestamp
when it started the worker, in the local variable "last_start_time",
in order to check whether wal_retrive_retry_interval elapsed since
the last startup of worker. If it has elapsed, the launcher sees
pg_subscription and starts new worker if necessary. This is for
limitting the startup of worker to once a wal_retrieve_retry_interval.

The bug was that the variable "last_start_time" was defined and
always initialized with 0 at the beginning of the launcher's main loop.
So even if it's set to the last timestamp in later phase of the loop,
it's always reset to 0. Therefore the launcher could not check
correctly whether wal_retrieve_retry_interval elapsed since
the last startup.

This patch moves the variable "last_start_time" outside the main loop
so that it will not be reset.

Reviewed-by: Petr Jelinek
Discussion: http://postgr.es/m/CAHGQGwGJrPO++XM4mFENAwpy1eGXKsGdguYv43GUgLgU-x8nTQ@mail.gmail.com
This commit is contained in:
Fujii Masao 2017-04-28 06:35:00 +09:00
parent 82ebbeb0ab
commit 9f11fcec66
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/replication/logical/launcher.c
View File

@ -781,6 +781,8 @@ ApplyLauncherWakeup(void)
void void
ApplyLauncherMain(Datum main_arg) ApplyLauncherMain(Datum main_arg)
{ {
TimestampTz last_start_time = 0;
ereport(DEBUG1, ereport(DEBUG1,
(errmsg("logical replication launcher started"))); (errmsg("logical replication launcher started")));
@ -812,7 +814,6 @@ ApplyLauncherMain(Datum main_arg)
MemoryContext subctx; MemoryContext subctx;
MemoryContext oldctx; MemoryContext oldctx;
TimestampTz now; TimestampTz now;
TimestampTz last_start_time = 0;
long wait_time = DEFAULT_NAPTIME_PER_CYCLE; long wait_time = DEFAULT_NAPTIME_PER_CYCLE;
now = GetCurrentTimestamp(); now = GetCurrentTimestamp();