mirror of
https://github.com/postgres/postgres.git
synced 2025-11-29 23:43:17 +03:00
Make a code-cleanup pass over the collations patch.
This patch is almost entirely cosmetic --- mostly cleaning up a lot of neglected comments, and fixing code layout problems in places where the patch made lines too long and then pgindent did weird things with that. I did find a bug-of-omission in equalTupleDescs().
This commit is contained in:
@@ -235,7 +235,8 @@ static void get_from_clause_item(Node *jtnode, Query *query,
|
||||
deparse_context *context);
|
||||
static void get_from_clause_alias(Alias *alias, RangeTblEntry *rte,
|
||||
deparse_context *context);
|
||||
static void get_from_clause_coldeflist(List *names, List *types, List *typmods, List *collations,
|
||||
static void get_from_clause_coldeflist(List *names,
|
||||
List *types, List *typmods, List *collations,
|
||||
deparse_context *context);
|
||||
static void get_opclass_name(Oid opclass, Oid actual_datatype,
|
||||
StringInfo buf);
|
||||
@@ -6617,7 +6618,8 @@ get_from_clause_alias(Alias *alias, RangeTblEntry *rte,
|
||||
* responsible for ensuring that an alias or AS is present before it.
|
||||
*/
|
||||
static void
|
||||
get_from_clause_coldeflist(List *names, List *types, List *typmods, List *collations,
|
||||
get_from_clause_coldeflist(List *names,
|
||||
List *types, List *typmods, List *collations,
|
||||
deparse_context *context)
|
||||
{
|
||||
StringInfo buf = context->buf;
|
||||
@@ -6651,7 +6653,8 @@ get_from_clause_coldeflist(List *names, List *types, List *typmods, List *collat
|
||||
appendStringInfo(buf, "%s %s",
|
||||
quote_identifier(attname),
|
||||
format_type_with_typemod(atttypid, atttypmod));
|
||||
if (attcollation && attcollation != DEFAULT_COLLATION_OID)
|
||||
if (OidIsValid(attcollation) &&
|
||||
attcollation != get_typcollation(atttypid))
|
||||
appendStringInfo(buf, " COLLATE %s",
|
||||
generate_collation_name(attcollation));
|
||||
i++;
|
||||
|
||||
4
src/backend/utils/cache/syscache.c
vendored
4
src/backend/utils/cache/syscache.c
vendored
@@ -277,7 +277,7 @@ static const struct cachedesc cacheinfo[] = {
|
||||
Anum_pg_collation_collnamespace,
|
||||
0
|
||||
},
|
||||
256
|
||||
64
|
||||
},
|
||||
{CollationRelationId, /* COLLOID */
|
||||
CollationOidIndexId,
|
||||
@@ -288,7 +288,7 @@ static const struct cachedesc cacheinfo[] = {
|
||||
0,
|
||||
0
|
||||
},
|
||||
256
|
||||
64
|
||||
},
|
||||
{ConversionRelationId, /* CONDEFAULT */
|
||||
ConversionDefaultIndexId,
|
||||
|
||||
Reference in New Issue
Block a user