database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

pg_upgrade: fix off-by-one mistake in snprintf

Browse Source 
snprintf counts trailing NUL towards the char limit.  Failing to account
for that was causing an invalid value to be passed to pg_resetxlog -l,
aborting the upgrade process.
This commit is contained in:
Alvaro Herrera
2012-06-28 23:37:27 -04:00
parent c1494b7330
commit 9e26326ad6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pg_upgrade/controldata.c
View File

@ -425,7 +425,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)
{ {
if (got_log_id && got_log_seg) if (got_log_id && got_log_seg)
{ {
snprintf(cluster->controldata.nextxlogfile, 24, "%08X%08X%08X", snprintf(cluster->controldata.nextxlogfile, 25, "%08X%08X%08X",
tli, logid, segno); tli, logid, segno);
got_nextxlogfile = true; got_nextxlogfile = true;
} }