database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Revert "Catalog NOT NULL constraints" and fallout

Browse Source 
This reverts commit e056c557ae and minor later fixes thereof.

There's a few problems in this new feature -- most notably regarding
pg_upgrade behavior, but others as well.  This new feature is not in any
way critical on its own, so instead of scrambling to fix it we revert it
and try again in early 17 with these issues in mind.

Discussion: https://postgr.es/m/3801207.1681057430@sss.pgh.pa.us
This commit is contained in:
Alvaro Herrera
2023-04-12 19:29:21 +02:00
parent 8e82db97b0
commit 9ce04b50e1
42 changed files with 648 additions and 2897 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/test/regress/sql/alter_table.sql
View File

@@ -852,7 +852,7 @@ create table atacc1 (test int not null);
alter table atacc1 add constraint "atacc1_pkey" primary key (test);
alter table atacc1 alter column test drop not null;
alter table atacc1 drop constraint "atacc1_pkey";
\d atacc1
alter table atacc1 alter column test drop not null;
insert into atacc1 values (null);
alter table atacc1 alter test set not null;
delete from atacc1;
@@ -917,6 +917,14 @@ insert into parent values (NULL);
insert into child (a, b) values (NULL, 'foo');
alter table only parent alter a set not null;
alter table child alter a set not null;
delete from parent;
alter table only parent alter a set not null;
insert into parent values (NULL);
alter table child alter a set not null;
insert into child (a, b) values (NULL, 'foo');
delete from child;
alter table child alter a set not null;
insert into child (a, b) values (NULL, 'foo');
drop table child;
drop table parent;
@@ -2334,22 +2342,6 @@ ALTER TABLE ataddindex
\d ataddindex
DROP TABLE ataddindex;
CREATE TABLE atnotnull1 ();
ALTER TABLE atnotnull1
ADD COLUMN a INT,
ALTER a SET NOT NULL;
ALTER TABLE atnotnull1
ADD COLUMN b INT,
ADD NOT NULL b;
ALTER TABLE atnotnull1
ADD COLUMN c INT,
ADD PRIMARY KEY (c);
SELECT conrelid::regclass, conname, contype, conkey,
(SELECT attname FROM pg_attribute WHERE attrelid = conrelid AND attnum = conkey[1]),
coninhcount, conislocal
FROM pg_constraint WHERE contype IN ('n','p') AND
conrelid IN ('atnotnull1'::regclass);
-- unsupported constraint types for partitioned tables
CREATE TABLE partitioned (
a int,