mirror of
https://github.com/postgres/postgres.git
synced 2025-06-11 20:28:21 +03:00
Include values of A_Const nodes in query jumbling
Like the implementation for node copy, write and read, this node
requires a custom implementation so as the query jumbling is able to
consider the correct value assigned to it, depending on its type (int,
float, bool, string, bitstring).
Based on a dump of pg_stat_statements from the regression database, this
would confuse the query jumbling of the following queries:
- SET.
- COPY TO with SELECT queries.
- START TRANSACTION with different isolation levels.
- ALTER TABLE with default expressions.
- CREATE TABLE with partition bounds.
Note that there may be a long-term argument in tracking the location of
such nodes so as query strings holding such nodes could be normalized,
but this is left as a separate discussion.
Oversight in 3db72eb
.
Discussion: https://postgr.es/m/Y9+HuYslMAP6yyPb@paquier.xyz
This commit is contained in:
@ -270,6 +270,14 @@ DROP TABLE IF EXISTS test \;
|
||||
Drop Table If Exists test \;
|
||||
DROP FUNCTION IF EXISTS PLUS_ONE(INTEGER);
|
||||
DROP FUNCTION PLUS_TWO(INTEGER);
|
||||
-- This SET query uses two different strings, still they count as one entry.
|
||||
SET work_mem = '1MB';
|
||||
Set work_mem = '1MB';
|
||||
SET work_mem = '2MB';
|
||||
RESET work_mem;
|
||||
SET enable_seqscan = off;
|
||||
SET enable_seqscan = on;
|
||||
RESET enable_seqscan;
|
||||
|
||||
SELECT query, calls, rows FROM pg_stat_statements ORDER BY query COLLATE "C";
|
||||
|
||||
|
Reference in New Issue
Block a user