database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-21 10:42:50 +03:00
Code Activity

Improve some code around cryptohash functions

Browse Source 
This adjusts some code related to recent changes for cryptohash
functions:
- Add a variable in md5.h to track down the size of a computed result,
moved from pgcrypto.  Note that pg_md5_hash() assumed a result of this
size already.
- Call explicit_bzero() on the hashed data when freeing the context for
fallback implementations.  For MD5, particularly, it would be annoying
to leave some non-zeroed data around.
- Clean up some code related to recent changes of uuid-ossp.  .gitignore
still included md5.c and a comment was incorrect.

Discussion: https://postgr.es/m/X9HXKTgrvJvYO7Oh@paquier.xyz
This commit is contained in:
Michael Paquier
2020-12-14 12:38:13 +09:00
parent df9274adf3
commit 9b584953e7
6 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/common/cryptohash.c
View File

@@ -197,6 +197,26 @@ pg_cryptohash_free(pg_cryptohash_ctx *ctx)
{
if (ctx == NULL)
return;
switch (ctx->type)
{
case PG_MD5:
explicit_bzero(ctx->data, sizeof(pg_md5_ctx));
break;
case PG_SHA224:
explicit_bzero(ctx->data, sizeof(pg_sha224_ctx));
break;
case PG_SHA256:
explicit_bzero(ctx->data, sizeof(pg_sha256_ctx));
break;
case PG_SHA384:
explicit_bzero(ctx->data, sizeof(pg_sha384_ctx));
break;
case PG_SHA512:
explicit_bzero(ctx->data, sizeof(pg_sha512_ctx));
break;
}
FREE(ctx->data);
explicit_bzero(ctx, sizeof(pg_cryptohash_ctx));
FREE(ctx);