database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

Fix hash_array

Browse Source 
Commit 054adca641ac1279dc8d9b74fda41948ac35e9a9 neglected to
initialize the type_id field of the synthesized type cache entry, so
it would make a new one on every call.

Also, better use the per-function memory context for this; otherwise
it leaks memory.

Discussion: https://www.postgresql.org/message-id/flat/17158-8a2ba823982537a4%40postgresql.org
This commit is contained in:
Peter Eisentraut 2021-09-15 11:59:34 +02:00
parent 6e6adbddbc
commit 9b2fd49057
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/utils/adt/arrayfuncs.c
View File

@ -3992,13 +3992,14 @@ hash_array(PG_FUNCTION_ARGS)
MemoryContext oldcontext; MemoryContext oldcontext;
TypeCacheEntry *record_typentry; TypeCacheEntry *record_typentry;
oldcontext = MemoryContextSwitchTo(CacheMemoryContext); oldcontext = MemoryContextSwitchTo(fcinfo->flinfo->fn_mcxt);
/* /*
* Make fake type cache entry structure. Note that we can't just * Make fake type cache entry structure. Note that we can't just
* modify typentry, since that points directly into the type cache. * modify typentry, since that points directly into the type cache.
*/ */
record_typentry = palloc(sizeof(*record_typentry)); record_typentry = palloc0(sizeof(*record_typentry));
record_typentry->type_id = element_type;
/* fill in what we need below */ /* fill in what we need below */
record_typentry->typlen = typentry->typlen; record_typentry->typlen = typentry->typlen;