From 995a9fb14f6aa81ad8eedaf4e8dce1b3e51105c0 Mon Sep 17 00:00:00 2001 From: John Naylor Date: Tue, 20 Dec 2022 14:13:14 +0700 Subject: [PATCH] Move variable increment to the end of the loop This is less error prone and matches the placement of other code in the file. Justin Pryzby Reviewed by Tom Lane Discussion: https://www.postgresql.org/message-id/20221123172436.GJ11463@telsasoft.com --- src/backend/utils/activity/backend_status.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/activity/backend_status.c b/src/backend/utils/activity/backend_status.c index 7ecf467b8cd..cf5582caf25 100644 --- a/src/backend/utils/activity/backend_status.c +++ b/src/backend/utils/activity/backend_status.c @@ -842,7 +842,6 @@ pgstat_read_current_status(void) CHECK_FOR_INTERRUPTS(); } - beentry++; /* Only valid entries get included into the local array */ if (localentry->backendStatus.st_procpid > 0) { @@ -871,6 +870,8 @@ pgstat_read_current_status(void) #endif localNumBackends++; } + + beentry++; } /* Set the pointer only after completion of a valid table */