database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.

Browse Source 
pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching
version number in pg_control, and that seems like an important thing to
preserve since recovering from corrupt pg_control is a prime reason to
need to run it.  However, that means you can try to run it against a
data directory of a different major version, which is at best useless
and at worst disastrous.  So as to provide some protection against that
type of pilot error, inspect PG_VERSION at startup and refuse to do
anything if it doesn't match.  PG_VERSION is read-only after initdb,
so it's unlikely to get corrupted, and even if it were corrupted it would
be easy to fix by hand.

This hazard has been there all along, so back-patch to all supported
branches.

Michael Paquier, with some kibitzing by me

Discussion: https://postgr.es/m/f4b8eb91-b934-8a0d-b3cc-68f06e2279d1@enterprisedb.com
This commit is contained in:
Tom Lane
2017-05-29 17:08:16 -04:00
parent dd1daa03bc
commit 98bff29074
2 changed files with 74 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
doc/src/sgml/ref/pg_resetxlog.sgml
View File

@ -281,6 +281,11 @@ PostgreSQL documentation
<command>pg_resetxlog</command> to run. But before you do
so, make doubly certain that there is no server process still alive.
</para>
<para>
<command>pg_resetxlog</command> works only with servers of the same
major version.
</para>
</refsect1>
<refsect1>