database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Check for NULL result from strdup

Browse Source 
Per Coverity Scan
This commit is contained in:
Alvaro Herrera
2013-07-23 17:38:32 -04:00
parent 5fbc3130b3
commit 980c24e1e8
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/interfaces/libpq/fe-secure.c
View File

@@ -1132,7 +1132,17 @@ initialize_SSL(PGconn *conn)
{ {
/* Colon, but not in second character, treat as engine:key */ /* Colon, but not in second character, treat as engine:key */
char *engine_str = strdup(conn->sslkey); char *engine_str = strdup(conn->sslkey);
char *engine_colon = strchr(engine_str, ':'); char *engine_colon;
if (engine_str == NULL)
{
printfPQExpBuffer(&conn->errorMessage,
libpq_gettext("out of memory\n"));
return -1;
}
/* cannot return NULL because we already checked before strdup */
engine_colon = strchr(engine_str, ':');
*engine_colon = '\0'; /* engine_str now has engine name */ *engine_colon = '\0'; /* engine_str now has engine name */
engine_colon++; /* engine_colon now has key name */ engine_colon++; /* engine_colon now has key name */