database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-16 15:02:33 +03:00
Code Activity

Ensure that EquivalenceClasses generated from ORDER BY keys contain proper

Browse Source 
RelabelType nodes when the sort key is binary-compatible with the sort
operator rather than having exactly its input type.  We did this correctly
for index columns but not sort keys, leading to failure to notice that
a varchar index matches an ORDER BY request.  This requires a bit more work
in make_sort_from_pathkeys, but not anyplace else that I can find.
Per bug report and subsequent discussion.
This commit is contained in:
Tom Lane
2007-11-02 18:54:15 +00:00
parent 65bd783614
commit 97ddfc9607
2 changed files with 44 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/optimizer/plan/createplan.c
View File

@@ -10,7 +10,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.231 2007/05/21 17:57:34 tgl Exp $
* $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.232 2007/11/02 18:54:15 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -2756,12 +2756,30 @@ make_sort_from_pathkeys(PlannerInfo *root, Plan *lefttree, List *pathkeys,
if (em->em_is_const || em->em_is_child)
continue;
tle = tlist_member((Node *) em->em_expr, tlist);
if (tle)
{
pk_datatype = em->em_datatype;
break; /* found expr already in tlist */
}
/*
* We can also use it if the pathkey expression is a relabel
* of the tlist entry. This is needed for binary-compatible
* cases (cf. make_pathkey_from_sortinfo).
*/
if (IsA(em->em_expr, RelabelType))
{
Expr *rtarg = ((RelabelType *) em->em_expr)->arg;
tle = tlist_member((Node *) rtarg, tlist);
if (tle)
{
pk_datatype = em->em_datatype;
break; /* found expr already in tlist */
}
}
}
if (!tle)
{