database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

When WCOs are present, disable direct foreign table modification.

Browse Source 
If the user modifies a view that has CHECK OPTIONs and this gets
translated into a modification to an underlying relation which happens
to be a foreign table, the check options should be enforced.  In the
normal code path, that was happening properly, but it was not working
properly for "direct" modification because the whole operation gets
pushed to the remote side in that case and we never have an option to
enforce the constraint against individual tuples.  Fix by disabling
direct modification when there is a need to enforce CHECK OPTIONs.

Etsuro Fujita, reviewed by Kyotaro Horiguchi and by me.

Discussion: http://postgr.es/m/f8a48f54-6f02-9c8a-5250-9791603171ee@lab.ntt.co.jp
This commit is contained in:
Robert Haas
2017-07-24 15:57:24 -04:00
parent 3a07ba1285
commit 971faefc24
4 changed files with 93 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
doc/src/sgml/postgres-fdw.sgml
View File

@ -488,8 +488,10 @@
<filename>postgres_fdw</> attempts to optimize the query execution by
sending the whole query to the remote server if there are no query
<literal>WHERE</> clauses that cannot be sent to the remote server,
no local joins for the query, and no row-level local <literal>BEFORE</> or
<literal>AFTER</> triggers on the target table. In <command>UPDATE</>,
no local joins for the query, no row-level local <literal>BEFORE</> or
<literal>AFTER</> triggers on the target table, and no
<literal>CHECK OPTION</> constraints from parent views.
In <command>UPDATE</>,
expressions to assign to target columns must use only built-in data types,
<literal>IMMUTABLE</> operators, or <literal>IMMUTABLE</> functions,
to reduce the risk of misexecution of the query.