database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Fix findoidjoins to recognize oidvector columns.

Browse Source 
Somehow we'd never noticed this oversight, even though it means
that such basic columns as pg_proc.proargtypes were not being
validated by the oidjoins test.  Correct the query and update
the test script with the newly-found dependencies.
This commit is contained in:
Tom Lane
2020-05-09 16:28:09 -04:00
parent ebeb3dea77
commit 96d175e3e2
4 changed files with 66 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/tools/findoidjoins/README
View File

@ -235,6 +235,11 @@ Join pg_catalog.pg_constraint.conpfeqop []=> pg_catalog.pg_operator.oid
Join pg_catalog.pg_constraint.conppeqop []=> pg_catalog.pg_operator.oid
Join pg_catalog.pg_constraint.conffeqop []=> pg_catalog.pg_operator.oid
Join pg_catalog.pg_constraint.conexclop []=> pg_catalog.pg_operator.oid
Join pg_catalog.pg_index.indcollation []=> pg_catalog.pg_collation.oid
Join pg_catalog.pg_index.indclass []=> pg_catalog.pg_opclass.oid
Join pg_catalog.pg_partitioned_table.partclass []=> pg_catalog.pg_opclass.oid
Join pg_catalog.pg_partitioned_table.partcollation []=> pg_catalog.pg_collation.oid
Join pg_catalog.pg_proc.proargtypes []=> pg_catalog.pg_type.oid
Join pg_catalog.pg_proc.proallargtypes []=> pg_catalog.pg_type.oid
---------------------------------------------------------------------------

2
src/tools/findoidjoins/findoidjoins.c
View File

@ -59,7 +59,6 @@ main(int argc, char **argv)
/* Get a list of system relations that have OIDs */
printfPQExpBuffer(&sql,
"SET search_path = public;"
"SELECT c.relname, (SELECT nspname FROM "
"pg_catalog.pg_namespace n WHERE n.oid = c.relnamespace) AS nspname "
"FROM pg_catalog.pg_class c "
@ -170,6 +169,7 @@ main(int argc, char **argv)
" AND c.relkind = " CppAsString2(RELKIND_RELATION)
" AND a.attrelid = c.oid"
" AND a.atttypid IN ('pg_catalog.oid[]'::regtype, "
" 'pg_catalog.oidvector'::regtype, "
" 'pg_catalog.regclass[]'::regtype, "
" 'pg_catalog.regoper[]'::regtype, "
" 'pg_catalog.regoperator[]'::regtype, "