From 963bafde8b225a123e31649f44e26ed930b2002c Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Fri, 20 Jul 2012 15:56:57 -0400 Subject: [PATCH] Remove prepared transactions from main isolation test schedule. There is no point in running this test when prepared transactions are disabled, which is the default. New make targets that include the test are provided. This will save some useless waste of cycles on buildfarm machines. Backpatch to 9.1 where these tests were introduced. --- src/test/isolation/Makefile | 7 +++++++ src/test/isolation/isolation_schedule | 1 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/test/isolation/Makefile b/src/test/isolation/Makefile index 80a8a25bb3f..f11fedd077c 100644 --- a/src/test/isolation/Makefile +++ b/src/test/isolation/Makefile @@ -75,6 +75,13 @@ maintainer-clean: distclean installcheck: all ./pg_isolation_regress --psqldir='$(PSQLDIR)' --inputdir=$(srcdir) --schedule=$(srcdir)/isolation_schedule +# Version of the install check test that includes the prepared_transactions test +# It only makes sense to run this if set up to use prepared transactions, +# via the postgresql.conf. +installcheck-prepared-txns: all + ./pg_isolation_regress --psqldir='$(PSQLDIR)' --inputdir=$(srcdir) --schedule=$(srcdir)/isolation_schedule prepared-transactions + + # We can't support "make check" because isolationtester requires libpq, and # in fact (on typical platforms using shared libraries) requires libpq to # already be installed. You could run "make install" and then run a check diff --git a/src/test/isolation/isolation_schedule b/src/test/isolation/isolation_schedule index 386ef78aac8..6ea8a29f490 100644 --- a/src/test/isolation/isolation_schedule +++ b/src/test/isolation/isolation_schedule @@ -9,4 +9,3 @@ test: ri-trigger test: partial-index test: two-ids test: multiple-row-versions -test: prepared-transactions