mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Avoid multiple foreign server connections when all use same user mapping.
Previously, postgres_fdw's connection cache was keyed by user OID and server OID, but this can lead to multiple connections when it's not really necessary. In particular, if all relevant users are mapped to the public user mapping, then their connection options are certainly the same, so one connection can be used for all of them. While we're cleaning things up here, drop the "server" argument to GetConnection(), which isn't really needed. This saves a few cycles because callers no longer have to look this up; the function itself does, but only when establishing a new connection, not when reusing an existing one. Ashutosh Bapat, with a few small changes by me.
This commit is contained in:
@ -193,6 +193,7 @@ GetUserMapping(Oid userid, Oid serverid)
|
||||
MappingUserName(userid))));
|
||||
|
||||
um = (UserMapping *) palloc(sizeof(UserMapping));
|
||||
um->umid = HeapTupleGetOid(tp);
|
||||
um->userid = userid;
|
||||
um->serverid = serverid;
|
||||
|
||||
|
@ -55,6 +55,7 @@ typedef struct ForeignServer
|
||||
|
||||
typedef struct UserMapping
|
||||
{
|
||||
Oid umid; /* Oid of user mapping */
|
||||
Oid userid; /* local user Oid */
|
||||
Oid serverid; /* server Oid */
|
||||
List *options; /* useoptions as DefElem list */
|
||||
|
Reference in New Issue
Block a user