database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-06 00:02:13 +03:00
Code Activity

Widen amount-to-flush arguments of FileWriteback and callers.

Browse Source 
It's silly to define these counts as narrower than they might someday
need to be.  Also, I believe that the BLCKSZ * nflush calculation in
mdwriteback was capable of overflowing an int.
This commit is contained in:
Tom Lane
2016-04-13 18:12:06 -04:00
parent fa11a09fed
commit 95ef43c430
5 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/storage/file/fd.c
View File

@@ -1538,28 +1538,28 @@ FilePrefetch(File file, off_t offset, int amount)
}
void
FileWriteback(File file, off_t offset, int amount)
FileWriteback(File file, off_t offset, off_t nbytes)
{
int returnCode;
Assert(FileIsValid(file));
DO_DB(elog(LOG, "FileWriteback: %d (%s) " INT64_FORMAT " %d",
DO_DB(elog(LOG, "FileWriteback: %d (%s) " INT64_FORMAT " " INT64_FORMAT,
file, VfdCache[file].fileName,
(int64) offset, amount));
(int64) offset, (int64) nbytes));
/*
* Caution: do not call pg_flush_data with amount = 0, it could trash the
* file's seek position.
* Caution: do not call pg_flush_data with nbytes = 0, it could trash the
* file's seek position. We prefer to define that as a no-op here.
*/
if (amount <= 0)
if (nbytes <= 0)
return;
returnCode = FileAccess(file);
if (returnCode < 0)
return;
pg_flush_data(VfdCache[file].fd, offset, amount);
pg_flush_data(VfdCache[file].fd, offset, nbytes);
}
int