database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-19 17:02:53 +03:00
Code Activity

Do not emit WAL for unlogged BRIN indexes

Browse Source 
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.

The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:

    FATAL:  could not create file "base/5/32819": File exists

Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail.com
Backpatch-through: 14
This commit is contained in:
Heikki Linnakangas
2025-12-18 15:08:48 +02:00
parent b47c50e566
commit 951b60f7ab
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/access/brin/brin_pageops.c
View File

@@ -891,7 +891,11 @@ brin_initialize_empty_new_buffer(Relation idxrel, Buffer buffer)
page = BufferGetPage(buffer); page = BufferGetPage(buffer);
brin_page_init(page, BRIN_PAGETYPE_REGULAR); brin_page_init(page, BRIN_PAGETYPE_REGULAR);
MarkBufferDirty(buffer); MarkBufferDirty(buffer);
log_newpage_buffer(buffer, true);
/* XLOG stuff */
if (RelationNeedsWAL(idxrel))
log_newpage_buffer(buffer, true);
END_CRIT_SECTION(); END_CRIT_SECTION();
/* /*