From 9356e43544287f1b727e6cb3350f98e35ecea752 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 9 May 2020 19:09:44 -0400 Subject: [PATCH] Doc: fix assorted misstatements of fact in catalog & system view docs. I made up a very crude hack to compare the docs with reality (as embodied in the system catalogs) ... and indeed they don't match everywhere. Missing oid columns, wrong data types, wrong "references" links, columns listed in the wrong order. None of this seems quite important enough to back-patch. --- doc/src/sgml/catalogs.sgml | 77 ++++++++++++++++++++-------- doc/src/sgml/information_schema.sgml | 4 +- doc/src/sgml/monitoring.sgml | 14 ++--- 3 files changed, 65 insertions(+), 30 deletions(-) diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index ce33df9e581..fcadba331db 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -3312,6 +3312,13 @@ SCRAM-SHA-256$<iteration count>:&l + + oid + oid + + Row identifier + + evtname name @@ -4879,7 +4886,7 @@ SCRAM-SHA-256$<iteration count>:&l partcollation oidvector - pg_opclass.oid + pg_collation.oid For each column in the partition key, this contains the OID of the collation to use for partitioning, or zero if the column is not @@ -4938,6 +4945,13 @@ SCRAM-SHA-256$<iteration count>:&l + + oid + oid + + Row identifier + + polname name @@ -5480,6 +5494,13 @@ SCRAM-SHA-256$<iteration count>:&l + + oid + oid + + Row identifier + + prpubid oid @@ -6432,6 +6453,13 @@ SCRAM-SHA-256$<iteration count>:&l + + oid + oid + + Row identifier + + stxrelid oid @@ -6677,16 +6705,6 @@ SCRAM-SHA-256$<iteration count>:&l If true, the subscription is enabled and should be replicating. - - subsynccommit - text - - - Contains the value of the synchronous_commit - setting for the subscription workers. - - - subconninfo text @@ -6702,6 +6720,16 @@ SCRAM-SHA-256$<iteration count>:&l for local replication origin name. + + subsynccommit + text + + + Contains the value of the synchronous_commit + setting for the subscription workers. + + + subpublications text[] @@ -6894,6 +6922,13 @@ SCRAM-SHA-256$<iteration count>:&l + + oid + oid + + Row identifier + + trftype oid @@ -9447,7 +9482,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx Name of policy - polpermissive + permissive text Is the policy permissive or restrictive? @@ -9844,7 +9879,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx database - text + name pg_database.datname The name of the database this slot is associated with, or null. Only logical slots have an associated database. @@ -10297,7 +10332,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx data_type regtype - pg_type.oid + pg_type.oid Data type of the sequence @@ -11075,8 +11110,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx statistics_owner - oid - pg_authid.oid + name + pg_authid.rolname Owner of the extended statistics @@ -11089,7 +11124,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx kinds - text[] + char[] Types of extended statistics enabled for this record @@ -11120,7 +11155,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx most_common_vals - anyarray + text[] A list of the most common combinations of values in the columns. @@ -11130,7 +11165,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx most_common_val_nulls - anyarray + bool[] A list of NULL flags for the most common combinations of values. @@ -11140,7 +11175,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx most_common_freqs - real[] + float8[] A list of the frequencies of the most common combinations, @@ -11151,7 +11186,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx most_common_base_freqs - real[] + float8[] A list of the base frequencies of the most common combinations, diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml index 7a995a1b649..3b32f0ae812 100644 --- a/doc/src/sgml/information_schema.sgml +++ b/doc/src/sgml/information_schema.sgml @@ -4498,7 +4498,7 @@ ORDER BY c.ordinal_position; result_cast_char_octet_length - character_data + cardinal_number Applies to a feature not available in PostgreSQL @@ -4558,7 +4558,7 @@ ORDER BY c.ordinal_position; result_cast_datetime_precision - character_data + cardinal_number Applies to a feature not available in PostgreSQL diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 6eb4df1d2e9..579ccd34d4f 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -2043,11 +2043,6 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i timestamp with time zone Send time of last reply message received from standby server - - spill_bytes - bigint - Amount of decoded transaction data spilled to disk. - spill_txns bigint @@ -2063,6 +2058,11 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i may get spilled repeatedly, and this counter gets incremented on every such invocation. + + spill_bytes + bigint + Amount of decoded transaction data spilled to disk. + @@ -2242,7 +2242,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i subname - text + name Name of the subscription @@ -3294,7 +3294,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i name - name + text name of the SLRU