database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Tweak make_inh_translation_lists() to check the common case wherein parent and

Browse Source 
child attnums are the same, before it grovels through each and every child
column looking for a name match.  Saves some time in large inheritance trees,
per example from Greg.
This commit is contained in:
Tom Lane
2007-04-21 05:56:41 +00:00
parent 402bd494ce
commit 925ca9d7de
1 changed files with 31 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/backend/optimizer/prep/prepunion.c
View File

@ -22,7 +22,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/prep/prepunion.c,v 1.140 2007/03/17 00:11:04 tgl Exp $ * $PostgreSQL: pgsql/src/backend/optimizer/prep/prepunion.c,v 1.141 2007/04/21 05:56:41 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -973,31 +973,42 @@ make_inh_translation_lists(Relation oldrelation, Relation newrelation,
* Otherwise we have to search for the matching column by name. * Otherwise we have to search for the matching column by name.
* There's no guarantee it'll have the same column position, because * There's no guarantee it'll have the same column position, because
* of cases like ALTER TABLE ADD COLUMN and multiple inheritance. * of cases like ALTER TABLE ADD COLUMN and multiple inheritance.
* However, in simple cases it will be the same column number, so
* try that before we go groveling through all the columns.
*
* Note: the test for (att = ...) != NULL cannot fail, it's just a
* notational device to include the assignment into the if-clause.
*/ */
for (new_attno = 0; new_attno < newnatts; new_attno++) if (old_attno < newnatts &&
(att = new_tupdesc->attrs[old_attno]) != NULL &&
!att->attisdropped && att->attinhcount != 0 &&
strcmp(attname, NameStr(att->attname)) == 0)
new_attno = old_attno;
else
{ {
att = new_tupdesc->attrs[new_attno]; for (new_attno = 0; new_attno < newnatts; new_attno++)
if (att->attisdropped || att->attinhcount == 0) {
continue; att = new_tupdesc->attrs[new_attno];
if (strcmp(attname, NameStr(att->attname)) != 0) if (!att->attisdropped && att->attinhcount != 0 &&
continue; strcmp(attname, NameStr(att->attname)) == 0)
/* Found it, check type */ break;
if (atttypid != att->atttypid || atttypmod != att->atttypmod) }
elog(ERROR, "attribute \"%s\" of relation \"%s\" does not match parent's type", if (new_attno >= newnatts)
elog(ERROR, "could not find inherited attribute \"%s\" of relation \"%s\"",
attname, RelationGetRelationName(newrelation)); attname, RelationGetRelationName(newrelation));
numbers = lappend_int(numbers, new_attno + 1);
vars = lappend(vars, makeVar(newvarno,
(AttrNumber) (new_attno + 1),
atttypid,
atttypmod,
0));
break;
} }
if (new_attno >= newnatts) /* Found it, check type */
elog(ERROR, "could not find inherited attribute \"%s\" of relation \"%s\"", if (atttypid != att->atttypid || atttypmod != att->atttypmod)
elog(ERROR, "attribute \"%s\" of relation \"%s\" does not match parent's type",
attname, RelationGetRelationName(newrelation)); attname, RelationGetRelationName(newrelation));
numbers = lappend_int(numbers, new_attno + 1);
vars = lappend(vars, makeVar(newvarno,
(AttrNumber) (new_attno + 1),
atttypid,
atttypmod,
0));
} }
*col_mappings = numbers; *col_mappings = numbers;