database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-26 01:22:12 +03:00
Code Activity

Add regression tests for pg_stat_progress_copy.tuples_skipped.

Browse Source 
This commit adds tests to verify that tuples_skipped in pg_stat_progress_copy
works as expected. While existing tests checked other fields, tuples_skipped
was previously untested.

This improves test coverage and ensures accurate tracking of skipped tuples.

Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Josef Šimánek <josef.simanek@gmail.com>
Discussion: https://postgr.es/m/CACJufxFazq-bfyhiO0KBojR=yOr84E25Rqf6mHB0Ow0KPidkKw@mail.gmail.com
This commit is contained in:
Fujii Masao
2025-03-04 23:56:49 +09:00
parent d2e7068392
commit 91ecb5e0bc
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/test/regress/expected/copy.out
View File

@ -181,7 +181,8 @@ begin
bytes_processed > 0 as has_bytes_processed, bytes_processed > 0 as has_bytes_processed,
bytes_total > 0 as has_bytes_total, bytes_total > 0 as has_bytes_total,
tuples_processed, tuples_processed,
tuples_excluded tuples_excluded,
tuples_skipped
from pg_stat_progress_copy from pg_stat_progress_copy
where pid = pg_backend_pid()) where pid = pg_backend_pid())
select into report (to_jsonb(r)) as value select into report (to_jsonb(r)) as value
@ -197,13 +198,17 @@ create trigger check_after_tab_progress_reporting
execute function notice_after_tab_progress_reporting(); execute function notice_after_tab_progress_reporting();
-- Generate COPY FROM report with PIPE. -- Generate COPY FROM report with PIPE.
copy tab_progress_reporting from stdin; copy tab_progress_reporting from stdin;
INFO: progress: {"type": "PIPE", "command": "COPY FROM", "relname": "tab_progress_reporting", "has_bytes_total": false, "tuples_excluded": 0, "tuples_processed": 3, "has_bytes_processed": true} INFO: progress: {"type": "PIPE", "command": "COPY FROM", "relname": "tab_progress_reporting", "tuples_skipped": 0, "has_bytes_total": false, "tuples_excluded": 0, "tuples_processed": 3, "has_bytes_processed": true}
-- Generate COPY FROM report with FILE, with some excluded tuples. -- Generate COPY FROM report with FILE, with some excluded tuples.
truncate tab_progress_reporting; truncate tab_progress_reporting;
\set filename :abs_srcdir '/data/emp.data' \set filename :abs_srcdir '/data/emp.data'
copy tab_progress_reporting from :'filename' copy tab_progress_reporting from :'filename'
where (salary < 2000); where (salary < 2000);
INFO: progress: {"type": "FILE", "command": "COPY FROM", "relname": "tab_progress_reporting", "has_bytes_total": true, "tuples_excluded": 1, "tuples_processed": 2, "has_bytes_processed": true} INFO: progress: {"type": "FILE", "command": "COPY FROM", "relname": "tab_progress_reporting", "tuples_skipped": 0, "has_bytes_total": true, "tuples_excluded": 1, "tuples_processed": 2, "has_bytes_processed": true}
-- Generate COPY FROM report with PIPE, with some skipped tuples.
copy tab_progress_reporting from stdin(on_error ignore);
NOTICE: 2 rows were skipped due to data type incompatibility
INFO: progress: {"type": "PIPE", "command": "COPY FROM", "relname": "tab_progress_reporting", "tuples_skipped": 2, "has_bytes_total": false, "tuples_excluded": 0, "tuples_processed": 1, "has_bytes_processed": true}
drop trigger check_after_tab_progress_reporting on tab_progress_reporting; drop trigger check_after_tab_progress_reporting on tab_progress_reporting;
drop function notice_after_tab_progress_reporting(); drop function notice_after_tab_progress_reporting();
drop table tab_progress_reporting; drop table tab_progress_reporting;

10
src/test/regress/sql/copy.sql
View File

@ -193,7 +193,8 @@ begin
bytes_processed > 0 as has_bytes_processed, bytes_processed > 0 as has_bytes_processed,
bytes_total > 0 as has_bytes_total, bytes_total > 0 as has_bytes_total,
tuples_processed, tuples_processed,
tuples_excluded tuples_excluded,
tuples_skipped
from pg_stat_progress_copy from pg_stat_progress_copy
where pid = pg_backend_pid()) where pid = pg_backend_pid())
select into report (to_jsonb(r)) as value select into report (to_jsonb(r)) as value
@ -222,6 +223,13 @@ truncate tab_progress_reporting;
copy tab_progress_reporting from :'filename' copy tab_progress_reporting from :'filename'
where (salary < 2000); where (salary < 2000);
-- Generate COPY FROM report with PIPE, with some skipped tuples.
copy tab_progress_reporting from stdin(on_error ignore);
sharon x (15,12) x sam
sharon 25 (15,12) 1000 sam
sharon y (15,12) x sam
\.
drop trigger check_after_tab_progress_reporting on tab_progress_reporting; drop trigger check_after_tab_progress_reporting on tab_progress_reporting;
drop function notice_after_tab_progress_reporting(); drop function notice_after_tab_progress_reporting();
drop table tab_progress_reporting; drop table tab_progress_reporting;