database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Make pg_createsubscriber warn if publisher has two-phase commit enabled.

Browse Source 
pg_createsubscriber currently always sets up logical replication
with two-phase commit disabled.  Improving that is not going to
happen for v17.  In the meantime, document the deficiency, and
adjust pg_createsubscriber so that it will emit a warning if
the source installation has max_prepared_transactions > 0.

Hayato Kuroda (some mods by Amit Kapila and me), per complaint from
Noah Misch

Discussion: https://postgr.es/m/20240623062157.97.nmisch@google.com
This commit is contained in:
Tom Lane
2024-06-30 14:24:14 -04:00
parent b3f5ccebd7
commit 917754557c
2 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
doc/src/sgml/ref/pg_createsubscriber.sgml
View File

@ -353,6 +353,17 @@ PostgreSQL documentation
<application>pg_createsubscriber</application>.
</para>
<para>
<application>pg_createsubscriber</application> sets up logical
replication with two-phase commit disabled. This means that any
prepared transactions will be replicated at the time
of <command>COMMIT PREPARED</command>, without advance preparation.
Once setup is complete, you can manually drop and re-create the
subscription(s) with
the <link linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
option enabled.
</para>
<para>
<application>pg_createsubscriber</application> changes the system
identifier using <application>pg_resetwal</application>. It would avoid