database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

I found the following bugs in the version 6.0 (dated 961229).

Browse Source 
At least the first two should be fixed before the final release of 6.0.

1)      There is a mismatch between the type declared in the catalog for
        the input/output attributes of pg_type and the actual type of
        values stored in the table.  The type of typinput, typoutput,
        typsend and typreceive are declared oid (26) while the values are
        regproc (24).  The error was there also in previous versions but
        nobody noticed it until an Assert has been added in ExecEvalVar.
        The effect is that it is now impossible to replace the typoutput
        of existing data types with new procs.

2)      The identd hba fails after the first time because the data read
        from the identd socket is not zero-terminated and strlen reports
        an incorrect length if the stack contains garbage, which usually
        happens after the first connection has been made.

3)      The new initdb wants to create itself the data directory. This
        implies that the parent directory must be writable by postgres and
        this may not always be desirable.  A better solution would be to
        allow the directory to be created by root and then filled by initdb.
        It would also nice to have some reasonable default for PGLIB and
        PGDATA like the previous version did.  This applies also to the
        postmaster executable.
This commit is contained in:
Bruce Momjian
1997-01-10 17:40:07 +00:00
parent daec84f09d
commit 90ff767d14
4 changed files with 34 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/interfaces/libpgtcl/Makefile
View File

@ -7,7 +7,7 @@
#
#
# IDENTIFICATION
# $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.6 1996/11/13 10:35:31 bryanh Exp $
# $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.7 1997/01/10 17:40:07 momjian Exp $
#
#-------------------------------------------------------------------------
@ -31,7 +31,16 @@ endif
OBJS= pgtcl.o pgtclCmds.o pgtclId.o
all: libpgtcl.a
ifdef LINUX_ELF
shlib := libpgtcl.so.1
install-shlib-dep := install-shlib
LDFLAGS += -L ../libpq -lpq
else
shlib :=
install-shlib-dep :=
endif
all: libpgtcl.a $(shlib)
libpgtcl.a: $(OBJS)
ifdef MK_NO_LORDER
@ -41,10 +50,15 @@ else
endif
$(RANLIB) libpgtcl.a
libpgtcl.so.1: $(OBJS)
$(CC) $(LDFLAGS) -shared $(OBJS) -o libpgtcl.so.1
rm -f libpgtcl.so
ln -s libpgtcl.so.1 libpgtcl.so
.PHONY: beforeinstall-headers install-headers
.PHONY: install install-libpgtcl
install: install-headers install-libpgtcl
install: install-headers install-libpgtcl $(install-shlib-dep)
install-headers: beforeinstall-headers libpgtcl.h
$(INSTALL) $(INSTLOPTS) libpgtcl.h $(HEADERDIR)/libpgtcl.h
@ -55,6 +69,12 @@ beforeinstall-headers:
install-libpgtcl: libpgtcl.a
$(INSTALL) $(INSTL_LIB_OPTS) libpgtcl.a $(DESTDIR)$(LIBDIR)/libpgtcl.a
install-shlib: libpgtcl.so.1
$(INSTALL) $(INSTL_LIB_OPTS) libpgtcl.so.1 \
$(DESTDIR)$(LIBDIR)/libpgtcl.so
rm -f $(DESTDIR)$(LIBDIR)/libpgtcl.so
ln -s libpgtcl.so.1 $(DESTDIR)$(LIBDIR)/libpgtcl.so
.PHONY: clean
clean:
rm -f $(OBJS)