From 901a9d53011573e45cd7b87682f0520ef3b0fd2d Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 24 Jun 2022 13:03:59 +0200 Subject: [PATCH] Remove unportable test The ssl test "IPv4 host with CIDR mask does not match" apparently has a portability problem. Some operating systems don't reject the host name specification "192.0.2.1/32" as an IP address, and that is then later rejected when the SNI is set, which results in a different error message that the test is supposed to verify. The value of the test has been questioned in the discussion, and it was suggested that removing it would be an acceptable fix, so that's what this is doing. Reported-by: Nazir Bilal Yavuz Bug: #17522 Discussion: https://www.postgresql.org/message-id/flat/17522-bfcd5c603b5f4daa%40postgresql.org --- src/test/ssl/t/001_ssltests.pl | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/001_ssltests.pl index c0b4a5739ce..707f4005af5 100644 --- a/src/test/ssl/t/001_ssltests.pl +++ b/src/test/ssl/t/001_ssltests.pl @@ -333,13 +333,6 @@ SKIP: qr/\Qserver certificate for "192.0.2.1" (and 1 other name) does not match host name "192.0.2.2"\E/ ); - $node->connect_fails( - "$common_connstr host=192.0.2.1/32", - "IPv4 host with CIDR mask does not match", - expected_stderr => - qr/\Qserver certificate for "192.0.2.1" (and 1 other name) does not match host name "192.0.2.1\/32"\E/ - ); - $node->connect_ok("$common_connstr host=2001:DB8::1", "host matching an IPv6 address (Subject Alternative Name 2)");