database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Sync PG_VERSION file in CREATE DATABASE.

Browse Source 
An OS crash could leave PG_VERSION empty or missing.  The same symptom
appeared in a backup by block device snapshot, taken after the next
checkpoint and before the OS flushes the PG_VERSION blocks.  Device
snapshots are not a documented backup method, however.  Back-patch to
v15, where commit 9c08aea6a3 introduced
STRATEGY=WAL_LOG and made it the default.

Discussion: https://postgr.es/m/20240130195003.0a.nmisch@google.com
This commit is contained in:
Noah Misch
2024-02-01 13:44:19 -08:00
parent d493bed28f
commit 8fa4a1ac61
4 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/commands/dbcommands.c
View File

@ -507,6 +507,14 @@ CreateDirAndVersionFile(char *dbpath, Oid dbid, Oid tsid, bool isRedo)
}
pgstat_report_wait_end();
pgstat_report_wait_start(WAIT_EVENT_VERSION_FILE_SYNC);
if (pg_fsync(fd) != 0)
ereport(data_sync_elevel(ERROR),
(errcode_for_file_access(),
errmsg("could not fsync file \"%s\": %m", versionfile)));
fsync_fname(dbpath, true);
pgstat_report_wait_end();
/* Close the version file. */
CloseTransientFile(fd);