database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Code review for inline-list patch.

Browse Source 
Make foreach macros less syntactically dangerous, and fix some typos in
evidently-never-tested ones.  Add missing slist_next_node and
slist_head_node functions.  Fix broken dlist_check code.  Assorted comment
improvements.
This commit is contained in:
Tom Lane
2012-10-18 16:47:07 -04:00
parent 2f2be7473b
commit 8f8d746478
2 changed files with 217 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/lib/ilist.c
View File

@ -24,9 +24,11 @@
#include "lib/ilist.h"
/*
* removes a node from a list
* Delete 'node' from list.
*
* Attention: O(n)
* It is not allowed to delete a 'node' which is is not in the list 'head'
*
* Caution: this is O(n)
*/
void
slist_delete(slist_head *head, slist_node *node)
@ -47,9 +49,9 @@ slist_delete(slist_head *head, slist_node *node)
}
last = cur;
}
Assert(found);
slist_check(head);
Assert(found);
}
#ifdef ILIST_DEBUG
@ -61,8 +63,11 @@ dlist_check(dlist_head *head)
{
dlist_node *cur;
if (head == NULL || !(&head->head))
elog(ERROR, "doubly linked list head is not properly initialized");
if (head == NULL)
elog(ERROR, "doubly linked list head address is NULL");
if (head->head.next == NULL && head->head.prev == NULL)
return; /* OK, initialized as zeroes */
/* iterate in forward direction */
for (cur = head->head.next; cur != &head->head; cur = cur->next)
@ -96,10 +101,10 @@ slist_check(slist_head *head)
slist_node *cur;
if (head == NULL)
elog(ERROR, "singly linked is NULL");
elog(ERROR, "singly linked list head address is NULL");
/*
* there isn't much we can test in a singly linked list other that it
* there isn't much we can test in a singly linked list except that it
* actually ends sometime, i.e. hasn't introduced a cycle or similar
*/
for (cur = head->head.next; cur != NULL; cur = cur->next)