database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

Fix format_type() to restore its old behavior.

Browse Source 
Commit a26116c6c accidentally changed the behavior of the SQL format_type()
function while refactoring.  For the reasons explained in that function's
comment, a NULL typemod argument should behave differently from a -1
argument.  Since we've managed to break this, add a regression test
memorializing the intended behavior.

In passing, be consistent about the type of the "flags" parameter.

Noted by Rushabh Lathia, though I revised the patch some more.

Discussion: https://postgr.es/m/CAGPqQf3RB2q-d2Awp_-x-Ur6aOxTUwnApt-vm-iTtceZxYnePg@mail.gmail.com
This commit is contained in:
Tom Lane
2018-03-01 11:37:46 -05:00
parent 1437824564
commit 8f72a57048
4 changed files with 46 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/postgres_fdw/deparse.c
View File

@ -854,7 +854,7 @@ foreign_expr_walker(Node *node,
static char *
deparse_type_name(Oid type_oid, int32 typemod)
{
uint8 flags = FORMAT_TYPE_TYPEMOD_GIVEN;
bits16 flags = FORMAT_TYPE_TYPEMOD_GIVEN;
if (!is_builtin(type_oid))
flags |= FORMAT_TYPE_FORCE_QUALIFY;