database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-09 06:21:09 +03:00
Code Activity

Make PG_MODULE_MAGIC required in shared libraries that are loaded into

Browse Source 
the server.  Per discussion, there seems no point in a waiting period
before making this required.
This commit is contained in:
Tom Lane
2006-05-31 20:58:09 +00:00
parent c269f0f1e2
commit 8f165ee13b
4 changed files with 54 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/utils/fmgr/dfmgr.c
View File

@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/fmgr/dfmgr.c,v 1.84 2006/05/30 21:21:30 tgl Exp $
* $PostgreSQL: pgsql/src/backend/utils/fmgr/dfmgr.c,v 1.85 2006/05/31 20:58:09 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -188,14 +188,14 @@ load_external_function(char *filename, char *funcname,
}
else
{
/*
* Currently we do not reject modules for not having a
* magic block, it would break every external module in
* existence. At some point though, this will become an ERROR.
*/
ereport(LOG,
(errmsg("library \"%s\" does not have a magic block",
fullname)));
/* try to unlink library */
pg_dlclose(file_scanner->handle);
free((char *) file_scanner);
/* complain */
ereport(ERROR,
(errmsg("incompatible library \"%s\": missing magic block",
fullname),
errhint("Extension libraries are now required to use the PG_MODULE_MAGIC macro.")));
}
/* OK to link it into list */