From 8f136af3c41c3b7e6474d6dd05238f11059f26f1 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 11 Apr 2024 17:19:20 +0900 Subject: [PATCH] Use correct datatype for xmin variables in slot.c Two variables storing a slot's effective_xmin and effective_catalog_xmin were saved as XLogRecPtr, which is incorrect as these should be TransactionIds. Oversight in 818fefd8fd44. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACVPSB74mrDTFezz-LV3Oi6F3SN71QA0oUHvndzi5dwTNg@mail.gmail.com Backpatch-through: 16 --- src/backend/replication/slot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c index 3bddaae022a..cebf44bb0fe 100644 --- a/src/backend/replication/slot.c +++ b/src/backend/replication/slot.c @@ -1545,8 +1545,8 @@ InvalidatePossiblyObsoleteSlot(ReplicationSlotInvalidationCause cause, int last_signaled_pid = 0; bool released_lock = false; bool terminated = false; - XLogRecPtr initial_effective_xmin = InvalidXLogRecPtr; - XLogRecPtr initial_catalog_effective_xmin = InvalidXLogRecPtr; + TransactionId initial_effective_xmin = InvalidTransactionId; + TransactionId initial_catalog_effective_xmin = InvalidTransactionId; XLogRecPtr initial_restart_lsn = InvalidXLogRecPtr; ReplicationSlotInvalidationCause invalidation_cause_prev PG_USED_FOR_ASSERTS_ONLY = RS_INVAL_NONE;