mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Reimplement planner's handling of MIN/MAX aggregate optimization (again).
Instead of playing cute games with pathkeys, just build a direct representation of the intended sub-select, and feed it through query_planner to get a Path for the index access. This is a bit slower than 9.1's previous method, since we'll duplicate most of the overhead of query_planner; but since the whole optimization only applies to rather simple single-table queries, that probably won't be much of a problem in practice. The advantage is that we get to do the right thing when there's a partial index that needs the implicit IS NOT NULL clause to be usable. Also, although this makes planagg.c be a bit more closely tied to the ordering of operations in grouping_planner, we can get rid of some coupling to lower-level parts of the planner. Per complaint from Marti Raudsepp.
This commit is contained in:
@ -1042,7 +1042,10 @@ grouping_planner(PlannerInfo *root, double tuple_fraction)
|
||||
count_agg_clauses(parse->havingQual, &agg_counts);
|
||||
|
||||
/*
|
||||
* Preprocess MIN/MAX aggregates, if any.
|
||||
* Preprocess MIN/MAX aggregates, if any. Note: be careful about
|
||||
* adding logic between here and the optimize_minmax_aggregates
|
||||
* call. Anything that is needed in MIN/MAX-optimizable cases
|
||||
* will have to be duplicated in planagg.c.
|
||||
*/
|
||||
preprocess_minmax_aggregates(root, tlist);
|
||||
}
|
||||
|
Reference in New Issue
Block a user