mirror of
https://github.com/postgres/postgres.git
synced 2025-07-11 10:01:57 +03:00
Reimplement planner's handling of MIN/MAX aggregate optimization (again).
Instead of playing cute games with pathkeys, just build a direct representation of the intended sub-select, and feed it through query_planner to get a Path for the index access. This is a bit slower than 9.1's previous method, since we'll duplicate most of the overhead of query_planner; but since the whole optimization only applies to rather simple single-table queries, that probably won't be much of a problem in practice. The advantage is that we get to do the right thing when there's a partial index that needs the implicit IS NOT NULL clause to be usable. Also, although this makes planagg.c be a bit more closely tied to the ordering of operations in grouping_planner, we can get rid of some coupling to lower-level parts of the planner. Per complaint from Marti Raudsepp.
This commit is contained in:
@ -1914,7 +1914,10 @@ _outMinMaxAggInfo(StringInfo str, MinMaxAggInfo *node)
|
||||
WRITE_OID_FIELD(aggfnoid);
|
||||
WRITE_OID_FIELD(aggsortop);
|
||||
WRITE_NODE_FIELD(target);
|
||||
WRITE_NODE_FIELD(pathkeys);
|
||||
/* We intentionally omit subroot --- too large, not interesting enough */
|
||||
WRITE_NODE_FIELD(path);
|
||||
WRITE_FLOAT_FIELD(pathcost, "%.2f");
|
||||
WRITE_NODE_FIELD(param);
|
||||
}
|
||||
|
||||
static void
|
||||
|
Reference in New Issue
Block a user