database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-13 16:22:44 +03:00
Code Activity

Improve BRIN documentation somewhat

Browse Source 
This removes some info about support procedures being used, which was
obsoleted by commit db5f98ab4f, as well as add some more documentation
on how to create new opclasses using the Minmax infrastructure.
(Hopefully we can get something similar for Inclusion as well.)

In passing, fix some obsolete mentions of "mmtuples" in source code
comments.

Backpatch to 9.5, where BRIN was introduced.
This commit is contained in:
Alvaro Herrera
2015-07-20 12:16:40 +02:00
parent b7ca57ac0e
commit 8d90736924
3 changed files with 77 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/brin/brin.c
View File

@@ -688,7 +688,7 @@ brinbuildempty(PG_FUNCTION_ARGS)
*
* XXX we could mark item tuples as "dirty" (when a minimum or maximum heap
* tuple is deleted), meaning the need to re-run summarization on the affected
* range. Need to an extra flag in mmtuples for that.
* range. Need to an extra flag in brintuples for that.
*/
Datum
brinbulkdelete(PG_FUNCTION_ARGS)

6
src/backend/access/brin/brin_xlog.c
View File

@@ -180,11 +180,11 @@ brin_xlog_samepage_update(XLogReaderState *record)
if (action == BLK_NEEDS_REDO)
{
Size tuplen;
BrinTuple *mmtuple;
BrinTuple *brintuple;
Page page;
OffsetNumber offnum;
mmtuple = (BrinTuple *) XLogRecGetBlockData(record, 0, &tuplen);
brintuple = (BrinTuple *) XLogRecGetBlockData(record, 0, &tuplen);
page = (Page) BufferGetPage(buffer);
@@ -193,7 +193,7 @@ brin_xlog_samepage_update(XLogReaderState *record)
elog(PANIC, "brin_xlog_samepage_update: invalid max offset number");
PageIndexDeleteNoCompact(page, &offnum, 1);
offnum = PageAddItem(page, (Item) mmtuple, tuplen, offnum, true, false);
offnum = PageAddItem(page, (Item) brintuple, tuplen, offnum, true, false);
if (offnum == InvalidOffsetNumber)
elog(PANIC, "brin_xlog_samepage_update: failed to add tuple");