diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c index ab375a3ea36..b52067910b9 100644 --- a/src/backend/executor/execQual.c +++ b/src/backend/executor/execQual.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.199.2.1 2007/02/02 00:07:27 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.199.2.2 2007/02/06 17:35:27 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -485,8 +485,11 @@ ExecEvalVar(ExprState *exprstate, ExprContext *econtext, * Note: we allow a reference to a dropped attribute. slot_getattr * will force a NULL result in such cases. * - * Note: we check typmod, but allow the case that the Var has - * unspecified typmod while the column has a specific typmod. + * Note: ideally we'd check typmod as well as typid, but that seems + * impractical at the moment: in many cases the tupdesc will have + * been generated by ExecTypeFromTL(), and that can't guarantee to + * generate an accurate typmod in all cases, because some expression + * node types don't carry typmod. */ if (attnum > 0) { @@ -502,9 +505,7 @@ ExecEvalVar(ExprState *exprstate, ExprContext *econtext, /* can't check type if dropped, since atttypid is probably 0 */ if (!attr->attisdropped) { - if (variable->vartype != attr->atttypid || - (variable->vartypmod != attr->atttypmod && - variable->vartypmod != -1)) + if (variable->vartype != attr->atttypid) ereport(ERROR, (errmsg("attribute %d has wrong type", attnum), errdetail("Table has type %s, but query expects %s.", @@ -3144,9 +3145,8 @@ ExecEvalFieldSelect(FieldSelectState *fstate, } /* Check for type mismatch --- possible after ALTER COLUMN TYPE? */ - if (fselect->resulttype != attr->atttypid || - (fselect->resulttypmod != attr->atttypmod && - fselect->resulttypmod != -1)) + /* As in ExecEvalVar, we should but can't check typmod */ + if (fselect->resulttype != attr->atttypid) ereport(ERROR, (errmsg("attribute %d has wrong type", fieldnum), errdetail("Table has type %s, but query expects %s.", diff --git a/src/backend/executor/execUtils.c b/src/backend/executor/execUtils.c index 909d9b198d0..1ef8300ba79 100644 --- a/src/backend/executor/execUtils.c +++ b/src/backend/executor/execUtils.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.140.2.2 2007/02/02 00:07:28 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.140.2.3 2007/02/06 17:35:27 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -632,10 +632,7 @@ ExecBuildProjectionInfo(List *targetList, break; } attr = inputDesc->attrs[variable->varattno - 1]; - if (attr->attisdropped || - variable->vartype != attr->atttypid || - (variable->vartypmod != attr->atttypmod && - variable->vartypmod != -1)) + if (attr->attisdropped || variable->vartype != attr->atttypid) { isVarList = false; break;