mirror of
https://github.com/postgres/postgres.git
synced 2025-11-06 07:49:08 +03:00
Teach parser to transform "x IS [NOT] DISTINCT FROM NULL" to a NullTest.
Now that we've nailed down the principle that NullTest with !argisrow is fully equivalent to SQL's IS [NOT] DISTINCT FROM NULL, let's teach the parser about it. This produces a slightly more compact parse tree and is much more amenable to optimization than a DistinctExpr, since the planner knows a good deal about NullTest and next to nothing about DistinctExpr. I'm not sure that there are all that many queries in the wild that could be improved by this, but at least one source of such cases is the patch just made to postgres_fdw to emit IS [NOT] DISTINCT FROM NULL when IS [NOT] NULL isn't semantically correct. No back-patch, since to the extent that this does affect planning results, it might be considered undesirable plan destabilization.
This commit is contained in:
@@ -237,6 +237,7 @@ typedef enum A_Expr_Kind
|
||||
AEXPR_OP_ANY, /* scalar op ANY (array) */
|
||||
AEXPR_OP_ALL, /* scalar op ALL (array) */
|
||||
AEXPR_DISTINCT, /* IS DISTINCT FROM - name must be "=" */
|
||||
AEXPR_NOT_DISTINCT, /* IS NOT DISTINCT FROM - name must be "=" */
|
||||
AEXPR_NULLIF, /* NULLIF - name must be "=" */
|
||||
AEXPR_OF, /* IS [NOT] OF - name must be "=" or "<>" */
|
||||
AEXPR_IN, /* [NOT] IN - name must be "=" or "<>" */
|
||||
|
||||
Reference in New Issue
Block a user