database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-27 23:21:58 +03:00
Code Activity

jit: Reference functions by name in IOCOERCE steps.

Browse Source 
Previously we used constant function pointer addresses, which prevents
inlining and other related optimizations.

Author: Andres Freund
Discussion: https://postgr.es/m/20191023163849.sosqbfs5yenocez3@alap3.anarazel.de
This commit is contained in:
Andres Freund
2020-02-06 19:09:06 -08:00
parent 1fdb7f9789
commit 8c2769405f
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/jit/llvm/llvmjit_expr.c
View File

@ -1261,10 +1261,10 @@ llvm_compile_expr(ExprState *state)
{ {
FunctionCallInfo fcinfo_out, FunctionCallInfo fcinfo_out,
fcinfo_in; fcinfo_in;
LLVMValueRef v_fn_out,
v_fn_in;
LLVMValueRef v_fcinfo_out, LLVMValueRef v_fcinfo_out,
v_fcinfo_in; v_fcinfo_in;
LLVMValueRef v_fn_addr_out,
v_fn_addr_in;
LLVMValueRef v_fcinfo_in_isnullp; LLVMValueRef v_fcinfo_in_isnullp;
LLVMValueRef v_retval; LLVMValueRef v_retval;
LLVMValueRef v_resvalue; LLVMValueRef v_resvalue;
@ -1290,10 +1290,10 @@ llvm_compile_expr(ExprState *state)
b_inputcall = l_bb_before_v(opblocks[opno + 1], b_inputcall = l_bb_before_v(opblocks[opno + 1],
"op.%d.inputcall", opno); "op.%d.inputcall", opno);
v_fn_out = llvm_function_reference(context, b, mod, fcinfo_out);
v_fn_in = llvm_function_reference(context, b, mod, fcinfo_in);
v_fcinfo_out = l_ptr_const(fcinfo_out, l_ptr(StructFunctionCallInfoData)); v_fcinfo_out = l_ptr_const(fcinfo_out, l_ptr(StructFunctionCallInfoData));
v_fcinfo_in = l_ptr_const(fcinfo_in, l_ptr(StructFunctionCallInfoData)); v_fcinfo_in = l_ptr_const(fcinfo_in, l_ptr(StructFunctionCallInfoData));
v_fn_addr_out = l_ptr_const(fcinfo_out->flinfo->fn_addr, TypePGFunction);
v_fn_addr_in = l_ptr_const(fcinfo_in->flinfo->fn_addr, TypePGFunction);
v_fcinfo_in_isnullp = v_fcinfo_in_isnullp =
LLVMBuildStructGEP(b, v_fcinfo_in, LLVMBuildStructGEP(b, v_fcinfo_in,
@ -1323,7 +1323,7 @@ llvm_compile_expr(ExprState *state)
l_sbool_const(0), l_sbool_const(0),
l_funcnullp(b, v_fcinfo_out, 0)); l_funcnullp(b, v_fcinfo_out, 0));
/* and call output function (can never return NULL) */ /* and call output function (can never return NULL) */
v_output = LLVMBuildCall(b, v_fn_addr_out, &v_fcinfo_out, v_output = LLVMBuildCall(b, v_fn_out, &v_fcinfo_out,
1, "funccall_coerce_out"); 1, "funccall_coerce_out");
LLVMBuildBr(b, b_input); LLVMBuildBr(b, b_input);
@ -1378,7 +1378,7 @@ llvm_compile_expr(ExprState *state)
/* reset fcinfo_in->isnull */ /* reset fcinfo_in->isnull */
LLVMBuildStore(b, l_sbool_const(0), v_fcinfo_in_isnullp); LLVMBuildStore(b, l_sbool_const(0), v_fcinfo_in_isnullp);
/* and call function */ /* and call function */
v_retval = LLVMBuildCall(b, v_fn_addr_in, &v_fcinfo_in, 1, v_retval = LLVMBuildCall(b, v_fn_in, &v_fcinfo_in, 1,
"funccall_iocoerce_in"); "funccall_iocoerce_in");
LLVMBuildStore(b, v_retval, v_resvaluep); LLVMBuildStore(b, v_retval, v_resvaluep);