database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Fix libpq example programs

Browse Source 
When these programs call pg_catalog.set_config, they need to check for
PGRES_TUPLES_OK instead of PGRES_COMMAND_OK.  Fix for
5770172cb0.

Reported-by: Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>
This commit is contained in:
Peter Eisentraut
2018-07-01 14:06:40 +02:00
parent d842139099
commit 8bfe83628b
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
doc/src/sgml/libpq.sgml
View File

@@ -8440,7 +8440,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);
@@ -8610,7 +8610,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
doc/src/sgml/lobj.sgml
View File

@@ -936,7 +936,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
src/test/examples/testlibpq.c
View File

@@ -51,7 +51,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
src/test/examples/testlibpq2.c
View File

@@ -80,7 +80,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
src/test/examples/testlibpq4.c
View File

@@ -37,7 +37,7 @@ check_prepare_conn(PGconn *conn, const char *dbName)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
src/test/examples/testlo.c
View File

@@ -235,7 +235,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);

2
src/test/examples/testlo64.c
View File

@@ -259,7 +259,7 @@ main(int argc, char **argv)
/* Set always-secure search path, so malicous users can't take control. */ /* Set always-secure search path, so malicous users can't take control. */
res = PQexec(conn, res = PQexec(conn,
"SELECT pg_catalog.set_config('search_path', '', false)"); "SELECT pg_catalog.set_config('search_path', '', false)");
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_TUPLES_OK)
{ {
fprintf(stderr, "SET failed: %s", PQerrorMessage(conn)); fprintf(stderr, "SET failed: %s", PQerrorMessage(conn));
PQclear(res); PQclear(res);