database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Add a WAIT option to DROP_REPLICATION_SLOT

Browse Source 
Commit 9915de6c1c changed the default behavior of
DROP_REPLICATION_SLOT so that it would wait until any session holding
the slot active would release it, instead of raising an error.  But
users are already depending on the original behavior, so revert to it by
default and add a WAIT option to invoke the new behavior.

Per complaint from Simone Gotti, in
Discussion: https://postgr.es/m/CAEvsy6Wgdf90O6pUvg2wSVXL2omH5OPC-38OD4Zzgk-FXavj3Q@mail.gmail.com
This commit is contained in:
Alvaro Herrera
2017-09-01 13:44:14 +02:00
parent 28915c7db4
commit 8ba6d50f92
8 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/src/sgml/logicaldecoding.sgml
View File

@ -303,7 +303,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
</listitem>
<listitem>
<para><literal>DROP_REPLICATION_SLOT <replaceable>slot_name</replaceable></literal></para>
<para><literal>DROP_REPLICATION_SLOT <replaceable>slot_name</replaceable></literal> <optional> <literal>WAIT</> </></para>
</listitem>
<listitem>

17
doc/src/sgml/protocol.sgml
View File

@ -2173,13 +2173,13 @@ The commands accepted in walsender mode are:
</varlistentry>
<varlistentry>
<term><literal>DROP_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</>
<term>
<literal>DROP_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</> <optional> <literal>WAIT</> </optional>
<indexterm><primary>DROP_REPLICATION_SLOT</primary></indexterm>
</term>
<listitem>
<para>
Drops a replication slot, freeing any reserved server-side resources. If
the slot is currently in use by an active connection, this command fails.
Drops a replication slot, freeing any reserved server-side resources.
If the slot is a logical slot that was created in a database other than
the database the walsender is connected to, this command fails.
</para>
@ -2192,6 +2192,17 @@ The commands accepted in walsender mode are:
</para>
</listitem>
</varlistentry>
<varlistentry>
<term><literal>WAIT</literal></term>
<listitem>
<para>
This option causes the command to wait if the slot is active until
it becomes inactive, instead of the default behavior of raising an
error.
</para>
</listitem>
</varlistentry>
</variablelist>
</listitem>
</varlistentry>